This is an automated email from the ASF dual-hosted git repository. alexey pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 99ade859168c7d6c53caf45905a665b3eade8d23 Author: Alexey Serbin <[email protected]> AuthorDate: Sat Feb 8 15:49:44 2020 -0800 [thirdparty] stip more features from libcurl It turned out that current configuration of libcurl in thirdparty picks up IDN2 (support for international domain names) and extra verification of cookies using PSL (Public Domain List) library, if corresponding libraries are available on the build machine. There aren't any known built-time or run-time use cases for these features at this point, so it makes sense to remove them. Explicitly configuring libcurl without these features helps to get rid of linkage errors on macOS in case of RELEASE builds if corresponding libraries are present: Undefined symbols for architecture x86_64: "_idn2_check_version", referenced from: _idnconvert_hostname in libcurl.a(libcurl_la-url.o) _curl_version in libcurl.a(libcurl_la-version.o) _curl_version_info in libcurl.a(libcurl_la-version.o) "_idn2_free", referenced from: _conn_free in libcurl.a(libcurl_la-url.o) _create_conn in libcurl.a(libcurl_la-url.o) "_idn2_lookup_ul", referenced from: _idnconvert_hostname in libcurl.a(libcurl_la-url.o) "_idn2_strerror", referenced from: _idnconvert_hostname in libcurl.a(libcurl_la-url.o) "_psl_builtin", referenced from: _Curl_psl_use in libcurl.a(libcurl_la-psl.o) "_psl_free", referenced from: _Curl_psl_destroy in libcurl.a(libcurl_la-psl.o) _Curl_psl_use in libcurl.a(libcurl_la-psl.o) "_psl_get_version", referenced from: _curl_version in libcurl.a(libcurl_la-version.o) "_psl_is_cookie_domain_acceptable", referenced from: _Curl_cookie_add in libcurl.a(libcurl_la-cookie.o) "_psl_latest", referenced from: _Curl_psl_use in libcurl.a(libcurl_la-psl.o) ld: symbol(s) not found for architecture x86_64 Change-Id: Iae1007773b45b0e9596b5a74d22930d4a107e508 Reviewed-on: http://gerrit.cloudera.org:8080/15195 Reviewed-by: Grant Henke <[email protected]> Tested-by: Kudu Jenkins --- thirdparty/build-definitions.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh index cf2e546..fe7fc7d 100644 --- a/thirdparty/build-definitions.sh +++ b/thirdparty/build-definitions.sh @@ -702,6 +702,8 @@ build_curl() { --disable-smtp \ --disable-telnet \ --disable-tftp \ + --without-libidn2 \ + --without-libpsl \ --without-librtmp \ --without-libssh2 \ --with-gssapi
