This is an automated email from the ASF dual-hosted git repository. granthenke pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit df7b2a63f8475d1e8d4268cba5568abb397396fe Author: Bankim Bhavsar <[email protected]> AuthorDate: Thu Feb 20 12:14:39 2020 -0800 [test] Fix flaky BloomFilterPredicate test min, max values need to be computed across all the values inserted in the column and not across subset of inclusive values. Tests: - Reproduced failure with dist-test. - With the fix, ran the BloomFilterPredicate test 1000 times on dist_test, no failures reported. Change-Id: I9a8fe34b59178f513224166d7ece7374ea2d1272 Reviewed-on: http://gerrit.cloudera.org:8080/15257 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Grant Henke <[email protected]> --- src/kudu/client/predicate-test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kudu/client/predicate-test.cc b/src/kudu/client/predicate-test.cc index 2db9828..1ed3904 100644 --- a/src/kudu/client/predicate-test.cc +++ b/src/kudu/client/predicate-test.cc @@ -1290,9 +1290,9 @@ TEST_F(BloomFilterPredicateTest, TestBloomFilterPredicate) { const unordered_set<int32_t> empty_set; auto all_values = CreateRandomUniqueIntegers<int32_t>(kNumAllValues, empty_set, &rand); + auto min_max_pair = std::minmax_element(all_values.begin(), all_values.end()); vector<int32_t> inclusive_values; ReservoirSample(all_values, kNumInclusiveValues, empty_set, &rand, &inclusive_values); - auto min_max_pair = std::minmax_element(inclusive_values.begin(), inclusive_values.end()); auto* inclusive_bf = CreateBloomFilterWithValues(inclusive_values); auto exclusive_values = CreateRandomUniqueIntegers<int32_t>(kNumExclusiveValues, all_values, &rand);
