This is an automated email from the ASF dual-hosted git repository. adar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 0923488fda7ce8d2222fa9ea676a0ece5f1d313b Author: Adar Dembo <[email protected]> AuthorDate: Thu Mar 19 00:27:41 2020 -0700 util: stop using namespaces There were a few holdouts of this, most likely from imported Impala code. It's a no-no for Kudu style, and "using namespace std" causes IWYU to recommend including <__config> when run against libc++. Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c Reviewed-on: http://gerrit.cloudera.org:8080/15491 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Adar Dembo <[email protected]> --- src/kudu/util/block_bloom_filter-test.cc | 5 +++-- src/kudu/util/logging.cc | 9 +++++---- src/kudu/util/url-coding-test.cc | 8 +++++--- src/kudu/util/url-coding.cc | 5 +++-- 4 files changed, 16 insertions(+), 11 deletions(-) diff --git a/src/kudu/util/block_bloom_filter-test.cc b/src/kudu/util/block_bloom_filter-test.cc index fa9b989..8815680 100644 --- a/src/kudu/util/block_bloom_filter-test.cc +++ b/src/kudu/util/block_bloom_filter-test.cc @@ -21,7 +21,6 @@ #include <cstdint> #include <cstdlib> #include <cstring> -#include <iosfwd> #include <memory> #include <unordered_set> #include <utility> @@ -40,7 +39,9 @@ DECLARE_bool(disable_blockbloomfilter_avx2); -using namespace std; // NOLINT(*) +using std::unique_ptr; +using std::unordered_set; +using std::vector; namespace kudu { diff --git a/src/kudu/util/logging.cc b/src/kudu/util/logging.cc index 36850c3..0ad4504 100644 --- a/src/kudu/util/logging.cc +++ b/src/kudu/util/logging.cc @@ -29,7 +29,6 @@ #include <utility> #include <boost/uuid/random_generator.hpp> -#include <boost/uuid/uuid.hpp> #include <boost/uuid/uuid_io.hpp> #include <gflags/gflags.h> #include <glog/logging.h> @@ -75,11 +74,13 @@ TAG_FLAG(max_log_files, experimental); bool logging_initialized = false; -using namespace std; // NOLINT(*) -using namespace boost::uuids; // NOLINT(*) - using base::SpinLock; using base::SpinLockHolder; +using boost::uuids::random_generator; +using std::string; +using std::ofstream; +using std::ostream; +using std::ostringstream; namespace kudu { diff --git a/src/kudu/util/url-coding-test.cc b/src/kudu/util/url-coding-test.cc index 3892772..aca738f 100644 --- a/src/kudu/util/url-coding-test.cc +++ b/src/kudu/util/url-coding-test.cc @@ -15,6 +15,8 @@ // specific language governing permissions and limitations // under the License. +#include "kudu/util/url-coding.h" + #include <cstring> #include <cstdint> #include <iostream> @@ -23,9 +25,9 @@ #include <gtest/gtest.h> -#include "kudu/util/url-coding.h" - -using namespace std; // NOLINT(*) +using std::ostringstream; +using std::string; +using std::vector; namespace kudu { diff --git a/src/kudu/util/url-coding.cc b/src/kudu/util/url-coding.cc index 81a2994..96a6a0f 100644 --- a/src/kudu/util/url-coding.cc +++ b/src/kudu/util/url-coding.cc @@ -14,7 +14,6 @@ // KIND, either express or implied. See the License for the // specific language governing permissions and limitations // under the License. -// #include "kudu/util/url-coding.h" @@ -33,9 +32,11 @@ #include <boost/function.hpp> #include <glog/logging.h> +using boost::archive::iterators::base64_from_binary; +using boost::archive::iterators::binary_from_base64; +using boost::archive::iterators::transform_width; using std::string; using std::vector; -using namespace boost::archive::iterators; // NOLINT(*) namespace kudu {
