This is an automated email from the ASF dual-hosted git repository. abukor pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 74a58cf4efa517b2dd2bb0d25757d834ce0ab98b Author: Alexey Serbin <[email protected]> AuthorDate: Wed Jul 8 18:24:38 2020 -0700 [gutil] fix assignment operator signature in DISALLOW_COPY_AND_ASSIGN Per C++ reference [1], a copy assignment operator returns the reference to the object. At least, with the standard signature of the copy assignment operator in DISALLOW_COPY_AND_ASSIGN it's easier to read error messages, if any. [1] https://en.cppreference.com/w/cpp/language/copy_assignment Change-Id: Ic33276bde2e7e35abcdc0044a8f406ffa81382af Reviewed-on: http://gerrit.cloudera.org:8080/16158 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar <[email protected]> --- src/kudu/gutil/macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kudu/gutil/macros.h b/src/kudu/gutil/macros.h index 696323b..7d0f53a 100644 --- a/src/kudu/gutil/macros.h +++ b/src/kudu/gutil/macros.h @@ -96,7 +96,7 @@ struct CompileAssert { #ifndef DISALLOW_COPY_AND_ASSIGN #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ TypeName(const TypeName&) = delete; \ - void operator=(const TypeName&) = delete + TypeName& operator=(const TypeName&) = delete #endif // An older, politically incorrect name for the above.
