This is an automated email from the ASF dual-hosted git repository. awong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 7ed3cfe225ac6812df45ebb8e34f8dbc8c20533a Author: Grant Henke <[email protected]> AuthorDate: Mon Jul 13 07:35:46 2020 -0500 KUDU-3030: Revert "Enable tcmalloc heap sampling by default" This reverts commit 3175ed07df9c9280adec08fea18d15acbd45a4dc which enable tcmalloc heap sampling by default. This commit can and should be re-applied once we identify and fix the intermittent crash reported in KUDU-3030. Change-Id: Ibfa6e9b3fcc34ae0e16a23cb4f732f17831677bf Reviewed-on: http://gerrit.cloudera.org:8080/16183 Tested-by: Grant Henke <[email protected]> Reviewed-by: Attila Bukor <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- src/kudu/util/flags.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/kudu/util/flags.cc b/src/kudu/util/flags.cc index b4eaf7e..4faa5be 100644 --- a/src/kudu/util/flags.cc +++ b/src/kudu/util/flags.cc @@ -84,12 +84,14 @@ DEFINE_string(heap_profile_path, "", "Output path to store heap profiles. If not TAG_FLAG(heap_profile_path, stable); TAG_FLAG(heap_profile_path, advanced); -DEFINE_int64(heap_sample_every_n_bytes, 512 * 1024, +DEFINE_int64(heap_sample_every_n_bytes, 0, "Enable heap occupancy sampling. If this flag is set to some positive " "value N, a memory allocation will be sampled approximately every N bytes. " "Lower values of N incur larger overhead but give more accurate results. " - "A value such as 512KB is a reasonable choice with relatively low overhead."); + "A value such as 524288 (512KB) is a reasonable choice with relatively " + "low overhead."); TAG_FLAG(heap_sample_every_n_bytes, advanced); +TAG_FLAG(heap_sample_every_n_bytes, experimental); #endif DEFINE_bool(disable_core_dumps, false, "Disable core dumps when this process crashes.");
