This is an automated email from the ASF dual-hosted git repository. alexey pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 8593d9180819e3f6f611c7b43df77b3f6713a9fc Author: Alexey Serbin <[email protected]> AuthorDate: Fri Jul 10 12:24:13 2020 -0700 [TestRideOverNtpInterruption] wider tolerance for clock error Increased the range of ASSERT_NEAR() for clock readings in the HybridClockTest.TestRideOverNtpInterruption test scenario. The motivation for this change was a test failure with the following message: src/kudu/clock/hybrid_clock-test.cc:342: Failure The difference between error_diff and \ clock_->time_service()->skew_ppm() * phys_diff.ToSeconds() \ is 13.892499999999984, which exceeds 10, \ where error_diff evaluates to 514, \ clock_->time_service()->skew_ppm() * phys_diff.ToSeconds() evaluates to 500.10750000000002, \ and 10 evaluates to 10. Change-Id: Ibf0689bbeb19f0f6079f1affdfa824e80ebcea89 Reviewed-on: http://gerrit.cloudera.org:8080/16167 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke <[email protected]> --- src/kudu/clock/hybrid_clock-test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kudu/clock/hybrid_clock-test.cc b/src/kudu/clock/hybrid_clock-test.cc index de74d35..50e6a26 100644 --- a/src/kudu/clock/hybrid_clock-test.cc +++ b/src/kudu/clock/hybrid_clock-test.cc @@ -362,7 +362,7 @@ TEST_F(HybridClockTest, TestRideOverNtpInterruption) { // The error should have increased based on the clock skew. int64_t error_diff = max_error_usec[1] - max_error_usec[0]; ASSERT_NEAR(error_diff, clock_.time_service()->skew_ppm() * phys_diff.ToSeconds(), - 10); + 20); // Now restore the ability to read the system clock, and // read it again.
