This is an automated email from the ASF dual-hosted git repository. awong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 4b0524f0bf8e81c004dd3f03a2467e9b0824b617 Author: Andrew Wong <[email protected]> AuthorDate: Fri Feb 5 19:45:00 2021 -0800 rpc: reduce logging when server is shutting down TxnCommitITest.TestRestartingWhileCommittingAndDeleting exercises the case where the client RPCs are sent to the tserver as the tserver is shutting down. This results in several log messages like: I0205 05:01:20.190737 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer I0205 05:01:20.190891 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer I0205 05:01:20.194700 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer until the RPC timeout is reached. This message only seems interesting to clients in cases outside the normal operation of a cluster, e.g. if the endpoint actually doesn't exist, versus if we're just starting up or shutting down. This patch adjusts the logging to reflect that. Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6 Reviewed-on: http://gerrit.cloudera.org:8080/17032 Reviewed-by: Hao Hao <[email protected]> Tested-by: Andrew Wong <[email protected]> --- src/kudu/rpc/messenger.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/kudu/rpc/messenger.cc b/src/kudu/rpc/messenger.cc index f161faf..08716b7 100644 --- a/src/kudu/rpc/messenger.cc +++ b/src/kudu/rpc/messenger.cc @@ -381,8 +381,9 @@ void Messenger::QueueInboundCall(unique_ptr<InboundCall> call) { if (PREDICT_FALSE(!service)) { const auto msg = Substitute("service $0 not registered on $1", call->remote_method().service_name(), name_); - LOG(INFO) << msg; if (state_ == kServicesRegistered) { + // NOTE: this message is only actually interesting if it's not transient. + LOG(INFO) << msg; call.release()->RespondFailure(ErrorStatusPB::ERROR_NO_SUCH_SERVICE, Status::NotFound(msg)); } else { call.release()->RespondFailure(
