This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 0bda51a9b851f0692f757d743548a823f9f1888b
Author: Alexey Serbin <[email protected]>
AuthorDate: Mon Feb 15 23:39:33 2021 -0800

    [tests] small cleanup on TxnCommitITest
    
    * removed unused variable in the TestRestartingWhileCommitting scenario
    * use non-empty transaction (i.e. insert several rows) for the
      TestRestartingWhileCommittingAndDeleting scenario
    
    The latter is important to keep the scenario successfully running
    when txn participants are registered automatically by tablet servers:
    that functionality comes in a follow-up patch.
    
    Change-Id: I47668ef244598edbdd7fcaef88f350f36deabede
    Reviewed-on: http://gerrit.cloudera.org:8080/17070
    Tested-by: Kudu Jenkins
    Reviewed-by: Andrew Wong <[email protected]>
---
 src/kudu/integration-tests/txn_commit-itest.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/kudu/integration-tests/txn_commit-itest.cc 
b/src/kudu/integration-tests/txn_commit-itest.cc
index 920d47e..c43fc1d 100644
--- a/src/kudu/integration-tests/txn_commit-itest.cc
+++ b/src/kudu/integration-tests/txn_commit-itest.cc
@@ -515,8 +515,6 @@ TEST_F(TxnCommitITest, TestRestartingWhileCommitting) {
 // assigned commit timestamps across participants.
 TEST_F(TxnCommitITest, TestRestartingWhileCommittingAndDeleting) {
   // First, create another table that we'll delete later on.
-  unordered_set<string> first_table_tablet_ids(
-      participant_ids_.begin(), participant_ids_.end());
   const string kSecondTableName = "default.second_table";
   TestWorkload w(cluster_.get());
   w.set_num_replicas(1);
@@ -540,6 +538,7 @@ TEST_F(TxnCommitITest, 
TestRestartingWhileCommittingAndDeleting) {
   shared_ptr<KuduTransaction> txn;
   shared_ptr<KuduSession> txn_session;
   ASSERT_OK(BeginTransaction(both_tables_participant_ids, &txn, &txn_session));
+  ASSERT_OK(InsertToSession(txn_session, initial_row_count_, kNumRowsPerTxn));
   FLAGS_txn_status_manager_inject_latency_finalize_commit_ms = 2000;
   ASSERT_OK(txn->Commit(/*wait*/false));
 

Reply via email to