This is an automated email from the ASF dual-hosted git repository.
bankim pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new a9f0547 [tools] fix build on macOS
a9f0547 is described below
commit a9f0547fbb9d4d99c8f9106ae26aad22e222127f
Author: Andrew Wong <[email protected]>
AuthorDate: Fri Apr 23 11:45:46 2021 -0700
[tools] fix build on macOS
This patch fixes a build error seen on macOS:
FAILED: lib/libkudu_tools_test_util.dylib
: &&
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-msse4.2 -Wall -Wno-sign-compare -Wno-comment -pthread -fno-strict-aliasing
-DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG -ggdb -Qunused-arguments
-Wno-ambiguous-member-template -Wdocumentation-deprecated-sy
nc -Wno-unknown-warning-option -Wno-address-of-packed-member -std=c++17 -g
-isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk
-mmacosx-version-min=10.15 -dynamiclib -Wl,-headerpad_max_install_names -o
lib/libkudu_tools_test_util.dylib -ins
tall_name @rpath/libkudu_tools_test_util.dylib
src/kudu/tools/CMakeFiles/kudu_tools_test_util.dir/tool_test_util.cc.o
-Wl,-rpath,/Users/awong/Repositories/kudu/build/debug/lib
-Wl,-rpath,/Users/awong/Repositories/kudu/thirdparty/installed/uninstrumented/lib
lib/libkudu_util.dylib lib/libblock_b
loom_filter_proto.dylib
../../thirdparty/installed/uninstrumented/lib/libcrcutil.dylib
../../thirdparty/installed/uninstrumented/lib/libgflags.dylib
lib/libgutil.dylib ../../thirdparty/installed/uninstrumented/lib/libglog.dylib
lib/libhash_proto.dylib lib/libhistogram_proto.dylib ../../thir
dparty/installed/uninstrumented/lib/libev.dylib
lib/libmaintenance_manager_proto.dylib lib/libmem_tracker_proto.dylib
lib/libpb_util_proto.dylib lib/libversion_info_proto.dylib
../../thirdparty/installed/uninstrumented/lib/libprotobuf.dylib
../../thirdparty/installed/uninstrumented/lib/libya
ml-cpp.dylib ../../thirdparty/installed/uninstrumented/lib/libz.dylib
../../thirdparty/installed/uninstrumented/lib/libtcmalloc.dylib && :
Undefined symbols for architecture x86_64:
"kudu::tools::GetKuduToolAbsolutePathSafe(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)", referenced from:
kudu::tools::GetKuduToolAbsolutePath() in tool_test_util.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
Change-Id: Icd385b5b7b499dcd106f9e0333e4d6f616c68f89
Reviewed-on: http://gerrit.cloudera.org:8080/17334
Reviewed-by: Bankim Bhavsar <[email protected]>
Tested-by: Kudu Jenkins
---
src/kudu/tools/CMakeLists.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/kudu/tools/CMakeLists.txt b/src/kudu/tools/CMakeLists.txt
index 84215c2..fa1ebed 100644
--- a/src/kudu/tools/CMakeLists.txt
+++ b/src/kudu/tools/CMakeLists.txt
@@ -155,6 +155,7 @@ add_library(kudu_tools_test_util
tool_test_util.cc
)
target_link_libraries(kudu_tools_test_util
+ kudu_tools_util
kudu_util
)
