[kudu] branch master updated: [clock] use GTEST_SKIP in BuiltinNtpWithMiniChronydTest

[alexey]

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 7673e0a  [clock] use GTEST_SKIP in BuiltinNtpWithMiniChronydTest
7673e0a is described below

commit 7673e0a687a3584c30a341bd2a8aa1dc7fc9a9b4
Author: Alexey Serbin <ale...@apache.org>
AuthorDate: Fri Jun 11 13:11:35 2021 -0700

    [clock] use GTEST_SKIP in BuiltinNtpWithMiniChronydTest
    
    Once switched to a newer version of gtest where GTEST_SKIP() is present,
    it make sense to use GTEST_SKIP() instead of simple return to have
    more accurate reports on passed/failed/skipped tests.
    
    This is a follow-up to 78bd6c04ef37ca8906379a587140bc646433e28c.
    
    Change-Id: I2b6fe6d8afb14e23a9f8b7766986b43040bfd7e9
    Reviewed-on: http://gerrit.cloudera.org:8080/17587
    Reviewed-by: Bankim Bhavsar <ban...@cloudera.com>
    Tested-by: Kudu Jenkins
---
 src/kudu/clock/ntp-test.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/kudu/clock/ntp-test.cc b/src/kudu/clock/ntp-test.cc
index 8227409..167c788 100644
--- a/src/kudu/clock/ntp-test.cc
+++ b/src/kudu/clock/ntp-test.cc
@@ -721,7 +721,7 @@ TEST_F(BuiltinNtpWithMiniChronydTest, 
CloudInstanceNtpServer) {
     if (!s.ok()) {
       ASSERT_TRUE(s.IsNotFound()) << s.ToString();
       LOG(WARNING) << "test is skipped: non-supported or non-cloud 
environment";
-      return;
+      GTEST_SKIP();
     }
   }
   {
@@ -733,7 +733,7 @@ TEST_F(BuiltinNtpWithMiniChronydTest, 
CloudInstanceNtpServer) {
       LOG(WARNING) << strings::Substitute(
           "test is skipped: $0 cloud instance doesn't provide NTP server",
           cloud::TypeToString(md->type()));
-      return;
+      GTEST_SKIP();
     }
   }