This is an automated email from the ASF dual-hosted git repository.
awong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new e5e2242 [test] deflake ToolTest.TableScanCustomBatchSize
e5e2242 is described below
commit e5e22422356dc9ab2d3af8631e6646e0c2dc003b
Author: Andrew Wong <[email protected]>
AuthorDate: Mon Aug 2 14:48:09 2021 -0700
[test] deflake ToolTest.TableScanCustomBatchSize
There seems to be a bug when running loadgen with AUTO_FLUSH_BACKGROUND
mode, wherein background write flushes aren't waited for before the
process is terminated, resulting in a leak report. I'll address the
underlying issue separately, but for now, this patch adjusts the test to
use fewer rows so no leaks are reported.
The flaky test dashboard reports the test as ~10% flaky. With this
patch, I ran it in ASAN and it passed 100/100 times.
Change-Id: I0740de18a3425cfd47aefe354b6a9fe05aa291cf
Reviewed-on: http://gerrit.cloudera.org:8080/17747
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
---
src/kudu/tools/kudu-tool-test.cc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/kudu/tools/kudu-tool-test.cc b/src/kudu/tools/kudu-tool-test.cc
index aa70e15..c8015df 100644
--- a/src/kudu/tools/kudu-tool-test.cc
+++ b/src/kudu/tools/kudu-tool-test.cc
@@ -4065,7 +4065,7 @@ TEST_F(ToolTest, TableScanCustomBatchSize) {
NO_FATALS(RunLoadgen(1,
{
"--num_threads=5",
- "--num_rows_per_thread=20000",
+ "--num_rows_per_thread=2000",
},
kTableName));
// Use 256 KiByte scan batch.
@@ -4074,11 +4074,11 @@ TEST_F(ToolTest, TableScanCustomBatchSize) {
string err;
vector<string> out_lines;
const auto s = RunTool(
- Substitute("table scan $0 $1 --scan_batch_size=262144",
+ Substitute("table scan $0 $1 --scan_batch_size=26214",
cluster_->master()->bound_rpc_addr().ToString(),
kTableName),
&out, &err, &out_lines);
ASSERT_TRUE(s.ok()) << s.ToString() << ": " << err;
- ASSERT_STR_CONTAINS(out, "Total count 100000 ");
+ ASSERT_STR_CONTAINS(out, "Total count 10000 ");
}
}