This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new e8bc5ce [clang-tidy] add modernize-{deprecated-headers,use-override}
e8bc5ce is described below
commit e8bc5ce92462ad4145f966f4cb589adffbd64405
Author: Alexey Serbin <[email protected]>
AuthorDate: Sat Jan 29 12:08:21 2022 -0800
[clang-tidy] add modernize-{deprecated-headers,use-override}
This patch adds modernize-deprecated-headers [1] and
modernize-use-override [2] checks for clang-tidy.
The former helps with changing the C-style headers into C++ ones: that
complements the IWYU functionality since the currently used IWYU version
suggests adding C-style headers, not C++ ones, and it's not clear what's
the timeline for addressing that.
The latter helps to remove extra 'virtual' keywords: I saw that in
a few recent patches posted for review, so I thought it would be nice
to automate catching those nits.
[1]
https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html
[2]
https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-use-override.html
Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Reviewed-on: http://gerrit.cloudera.org:8080/18182
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Attila Bukor <[email protected]>
---
src/kudu/.clang-tidy | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/kudu/.clang-tidy b/src/kudu/.clang-tidy
index a1c3162..7e8e813 100644
--- a/src/kudu/.clang-tidy
+++ b/src/kudu/.clang-tidy
@@ -66,11 +66,13 @@ Checks: >-
misc-*,
-misc-non-private-member-variables-in-classes,
-modernize-*,
+ modernize-deprecated-headers,
modernize-make-shared,
modernize-pass-by-value,
modernize-shrink-to-fit,
modernize-use-emplace,
modernize-use-nullptr,
+ modernize-use-override,
performance-*,
readability-*,
-readability-braces-around-statements,
