This is an automated email from the ASF dual-hosted git repository. laiyingchun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit f1522c716f37e6a9db80de77a9783e0c48027a61 Author: Alexey Serbin <[email protected]> AuthorDate: Tue Jul 12 23:16:28 2022 -0700 KUDU-2671 updated comments in C++ client API Since the functionality of range-specific hash schemas becomes ready to use, this patch removes the corresponding warning from the inline documentation in the C++ client API. I also updated a few more comments around to use already established terminology and wording. This patch doesn't have any functional changes. Change-Id: Ibc0ac12354dc265e1a9a651e47be08b46338defd Reviewed-on: http://gerrit.cloudera.org:8080/18725 Tested-by: Kudu Jenkins Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> --- src/kudu/client/client.h | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/kudu/client/client.h b/src/kudu/client/client.h index 5fabee2ac..f2d07e2d5 100644 --- a/src/kudu/client/client.h +++ b/src/kudu/client/client.h @@ -1315,7 +1315,7 @@ class KUDU_EXPORT KuduTableCreator { RangePartitionBound lower_bound_type = INCLUSIVE_BOUND, RangePartitionBound upper_bound_type = EXCLUSIVE_BOUND); - /// Add a range partition with a custom hash bucket schema. + /// Add a range partition with a custom hash schema. /// /// This method allows adding a range partition which has hash partitioning /// schema different from the table-wide one. @@ -1326,11 +1326,9 @@ class KUDU_EXPORT KuduTableCreator { /// @li To create a range with the table-wide hash schema, use /// @c KuduTableCreator::add_range_partition() instead. /// - /// @warning This functionality isn't fully implemented yet. - /// /// @param [in] partition - /// Range partition with custom hash bucket schema. - /// The KuduTableCreator object takes ownership of the parameter. + /// Range partition with range-specific hash schema. + /// The KuduTableCreator object takes ownership of the partition object. /// @return Reference to the modified table creator. KuduTableCreator& add_custom_range_partition( KuduRangePartition* partition); @@ -1906,8 +1904,7 @@ class KUDU_EXPORT KuduTableAlterer { /// defaults to 5 minutes. /// /// @param [in] partition - /// The Kudu Range partition to be created. This Kudu Range partition can - /// have a custom hash schema defined. + /// The range partition to be created: it can have a custom hash schema. /// @return Raw pointer to this alterer object. KuduTableAlterer* AddRangePartition( KuduTableCreator::KuduRangePartition* partition);
