This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new e649d16d4 [util] address TODO to remove dummy encryption key
e649d16d4 is described below
commit e649d16d40aeecdb8b63bba7f3631b5fa910ea26
Author: Alexey Serbin <[email protected]>
AuthorDate: Wed Aug 24 16:10:57 2022 -0700
[util] address TODO to remove dummy encryption key
I noticed compiler's warning on unused variable and realized it's time
to address corresponding TODO in util/env_posix.cc.
This patch doesn't contain any functional modifications.
Change-Id: I09be400428b83fb3f5c8494df54f271bb4b0b33c
Reviewed-on: http://gerrit.cloudera.org:8080/18904
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <[email protected]>
Reviewed-by: Attila Bukor <[email protected]>
---
src/kudu/util/env_posix.cc | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/src/kudu/util/env_posix.cc b/src/kudu/util/env_posix.cc
index 7a68628bf..82b4d9398 100644
--- a/src/kudu/util/env_posix.cc
+++ b/src/kudu/util/env_posix.cc
@@ -22,14 +22,12 @@
#include <algorithm>
#include <cerrno>
#include <climits>
-#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <cstdlib>
#include <cstring>
#include <ctime>
#include <functional>
-#include <map>
#include <memory>
#include <numeric>
#include <optional>
@@ -271,15 +269,6 @@ struct EncryptionHeader {
uint8_t key[32];
};
-// KUDU-3316: This is the key temporarily used for all encrypion. Obviously,
-// this is not secure and MUST be removed and replaced with real keys once the
-// key infra is in place.
-// TODO(abukor): delete this.
-const struct EncryptionHeader kDummyEncryptionKey = {
- EncryptionAlgorithm::AES128ECB,
- {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 42},
-};
-
const EVP_CIPHER* GetEVPCipher(EncryptionAlgorithm algorithm) {
switch (algorithm) {
case EncryptionAlgorithm::AES128CTR:
