This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new ed648cf8a KUDU-3425 fix flakiness in TestSnapshotScanBeforeAHM
ed648cf8a is described below
commit ed648cf8a2491e78f3d693a8c1be9077ed064864
Author: Alexey Serbin <[email protected]>
AuthorDate: Mon Nov 28 16:22:11 2022 -0800
KUDU-3425 fix flakiness in TestSnapshotScanBeforeAHM
This patch fixes the flakiness in the TestSnapshotScanBeforeAHM scenario
of the TabletHistoryGcITest test. The root cause was in
IsAlterTableDone() RPC reporting 'all is done' prior the tablet replica
that served the scan request has received the update on the custom
config for the scanned table.
Setting replication factor to 1 from default 3 made the scenario stable.
before: 19 out of 1024 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1669681704.94942
after: 0 out of 1024 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1669686405.116123
Change-Id: Ib31e18c2a5ae68d05b4b0b0db15ff1cd00ac240b
Reviewed-on: http://gerrit.cloudera.org:8080/19284
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Yifan Zhang <[email protected]>
---
src/kudu/integration-tests/tablet_history_gc-itest.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/kudu/integration-tests/tablet_history_gc-itest.cc
b/src/kudu/integration-tests/tablet_history_gc-itest.cc
index cd7299857..d1de72ff1 100644
--- a/src/kudu/integration-tests/tablet_history_gc-itest.cc
+++ b/src/kudu/integration-tests/tablet_history_gc-itest.cc
@@ -37,10 +37,8 @@
#include "kudu/client/scan_batch.h"
#include "kudu/client/shared_ptr.h" // IWYU pragma: keep
#include "kudu/client/write_op.h"
-#include "kudu/clock/clock.h"
#include "kudu/clock/hybrid_clock.h"
#include "kudu/clock/mock_ntp.h"
-#include "kudu/clock/time_service.h"
#include "kudu/common/partial_row.h"
#include "kudu/common/schema.h"
#include "kudu/common/timestamp.h"
@@ -139,6 +137,8 @@ TEST_F(TabletHistoryGcITest, TestSnapshotScanBeforeAHM) {
// Create a tablet so we can scan it.
TestWorkload workload(cluster_.get());
+ // TODO(KUDU-3424): remove the customization once the issue is fixed
+ workload.set_num_replicas(1);
workload.Setup();
auto open_scanner_func = [](KuduClient* client) {
