This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new 7dce54aa6 [thirdparty] build RocksDB without liburing
7dce54aa6 is described below
commit 7dce54aa6d8544160c0bd185c7a148b597d48a7f
Author: Alexey Serbin <[email protected]>
AuthorDate: Fri Dec 2 19:15:07 2022 -0800
[thirdparty] build RocksDB without liburing
As of 7.7.3 version, RocksDB picks up liburing by default if it's
present on the build machine, and it doesn't error out if the library
isn't found. Since we don't yet have the liburing in Kudu's thirdparty,
that might result in unpredictable run-time dependencies.
For now, let's explicitly disable building RocksDB with liburing to
have more predictable build outcomes with RocksDB. Probably, at some
point it makes sense add liburing to Kudu's thirdparty and re-enable
building RocksDB with liburing if performance tests show much better
results when using the library.
Change-Id: Ia5ac4fb18c90a18f0ae6f96f36888d46d0a4d264
Reviewed-on: http://gerrit.cloudera.org:8080/19317
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <[email protected]>
---
thirdparty/build-definitions.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index e3d44416c..95f485c6f 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -1170,6 +1170,7 @@ build_rocksdb() {
-DWITH_TOOLS=OFF \
-DWITH_TRACE_TOOLS=OFF \
-DWITH_JNI=OFF \
+ -DWITH_LIBURING=OFF \
-DWITH_LZ4=ON \
-DWITH_ZSTD=OFF \
-DWITH_SNAPPY=ON \
