This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new 012f6003e LookupRpc use the meta_cache's client
012f6003e is described below
commit 012f6003e04b24bbda9f57004157c62f772cba78
Author: Ádám Bakai <[email protected]>
AuthorDate: Wed Nov 30 13:27:34 2022 +0100
LookupRpc use the meta_cache's client
If kudu::internal::LookupRpc is consturcted it gets access to two
clients, one from the table and one from the meta_cache. They can be
different when the table was created with an other client. This can be
problematic if KuduSession::Apply(KuduWriteOperation*) is used because
the RPC timeout is extracted from the operation's table's client
instead of the session's client.
Change-Id: Ib5351b6d651af120b3f69a34ab1e40a05e9c535b
Reviewed-on: http://gerrit.cloudera.org:8080/19321
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
---
src/kudu/client/meta_cache.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/client/meta_cache.cc b/src/kudu/client/meta_cache.cc
index f47b1fd6f..fed115d04 100644
--- a/src/kudu/client/meta_cache.cc
+++ b/src/kudu/client/meta_cache.cc
@@ -849,7 +849,7 @@ LookupRpc::LookupRpc(scoped_refptr<MetaCache> meta_cache,
const MonoTime& deadline,
MetaCache::LookupType lookup_type,
ReplicaController::Visibility replica_visibility)
- : AsyncLeaderMasterRpc(deadline, table->client(), BackoffType::LINEAR,
req_, &resp_,
+ : AsyncLeaderMasterRpc(deadline, meta_cache->client_, BackoffType::LINEAR,
req_, &resp_,
&MasterServiceProxy::GetTableLocationsAsync,
"LookupRpc", std::move(user_cb), {}),
meta_cache_(std::move(meta_cache)),
