This is an automated email from the ASF dual-hosted git repository.
laiyingchun pushed a commit to branch branch-1.17.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/branch-1.17.x by this push:
new 9613d12fa [java] alternative distro for Gradle propdeps plugin
9613d12fa is described below
commit 9613d12fa9d5fb780ced42d8c95f2465d6db892a
Author: Alexey Serbin <[email protected]>
AuthorDate: Wed May 31 10:47:21 2023 -0700
[java] alternative distro for Gradle propdeps plugin
This patch addresses Gradle build failure due to inability to fetch
the required propdeps plugin from repo.spring.io artifactory instance
(a.k.a. repository) anonymously. As it turned out, anonymous access
and dependency resolution using in 'plugins-release' has been disabled
as of end of January 2023 [1].
Without this patch, if the gradle's cache (usually in $HOME/.gradle)
had been cleaned, building Kudu would fail while trying to build gradlew
as a part of the build. The error message looked like the following:
Could not GET
'https://repo.spring.io/plugins-release/io/spring/gradle/propdeps-plugin/0.0.10.RELEASE/propdeps-plugin-0.0.10.RELEASE.pom'.
Received status code 401 from server
This patch updates the gradle's configuration to use cn.bestwu.propdeps
plugin [2] instead of propdeps, since the former looks to be compatible
with propdeps and is still available at https://plugins.gradle.org/m2/
at MavenCentral [3]. Also, cn.bestwu.propdeps is the authoritative
result of search for 'propdeps' at plugins.gradle.org [4].
Ideally, it would be great to get rid of Maven-like scopes 'provided'
and 'optional', converting them into Gradle's 'compileOnly'. However,
that requires many changes in the code because of issues with
annotations like @Nonnull, @Nullable, etc. That will be taken care of
in a separate changelist, while this patch fixes Kudu build failure.
[1]
https://spring.io/blog/2022/12/14/notice-of-permissions-changes-to-repo-spring-io-january-2023
[2] https://plugins.gradle.org/plugin/cn.bestwu.propdeps
[3]
https://mvnrepository.com/artifact/gradle.plugin.cn.bestwu.gradle/propdeps-plugin
[4] https://plugins.gradle.org/search?term=propdeps
Change-Id: Ied311c2a3489b707024d2873a70fd5d84e51844d
Reviewed-on: http://gerrit.cloudera.org:8080/19961
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Abhishek Chennaka <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
Reviewed-on: http://gerrit.cloudera.org:8080/19963
Reviewed-by: Yingchun Lai <[email protected]>
Tested-by: Kudu Jenkins
---
java/buildSrc/build.gradle | 3 +--
java/gradle/scopes.gradle | 8 ++++----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/java/buildSrc/build.gradle b/java/buildSrc/build.gradle
index 987df4536..28f03f1ec 100644
--- a/java/buildSrc/build.gradle
+++ b/java/buildSrc/build.gradle
@@ -21,7 +21,6 @@ repositories {
mavenCentral()
jcenter()
maven { url "https://clojars.org/repo"; } // Only used for the clojure plugin
below.
- maven { url "https://repo.spring.io/plugins-release"; } // Only used for the
propdeps plugin below.
maven { url "https://plugins.gradle.org/m2/"; }
}
@@ -35,7 +34,7 @@ dependencies {
compile "com.google.protobuf:protobuf-gradle-plugin:0.8.18"
compile "com.netflix.nebula:nebula-clojure-plugin:10.1.1"
compile "gradle.plugin.com.github.spotbugs.snom:spotbugs-gradle-plugin:4.7.0"
- compile "io.spring.gradle:propdeps-plugin:0.0.10.RELEASE"
+ compile "gradle.plugin.cn.bestwu.gradle:propdeps-plugin:0.0.10"
compile "net.ltgt.gradle:gradle-errorprone-plugin:2.0.2"
compile "ru.vyarus:gradle-animalsniffer-plugin:1.5.4"
compile "com.google.code.gson:gson:2.8.9"
diff --git a/java/gradle/scopes.gradle b/java/gradle/scopes.gradle
index 10bede3a3..84a94a3d8 100644
--- a/java/gradle/scopes.gradle
+++ b/java/gradle/scopes.gradle
@@ -17,7 +17,7 @@
// This file adds provided scope and optional maven support.
-apply plugin: "propdeps"
-apply plugin: "propdeps-eclipse"
-apply plugin: "propdeps-idea"
-apply plugin: "propdeps-maven"
+apply plugin: "cn.bestwu.propdeps"
+apply plugin: "cn.bestwu.propdeps-eclipse"
+apply plugin: "cn.bestwu.propdeps-idea"
+apply plugin: "cn.bestwu.propdeps-maven"
