This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new fcd311964 Remove unused parameter
fcd311964 is described below
commit fcd311964c12cfac42043b985f929c30976135eb
Author: xinghuayu007 <[email protected]>
AuthorDate: Thu Oct 12 15:10:17 2023 +0800
Remove unused parameter
Parameter is_leader is not used in the implement of
function Status Tablet::DecodeWriteOperations, therefore
remove it.
Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
Reviewed-on: http://gerrit.cloudera.org:8080/20565
Reviewed-by: Alexey Serbin <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
---
src/kudu/tablet/ops/write_op.cc | 2 +-
src/kudu/tablet/tablet.cc | 3 +--
src/kudu/tablet/tablet.h | 3 +--
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/kudu/tablet/ops/write_op.cc b/src/kudu/tablet/ops/write_op.cc
index 208f33c07..816969a11 100644
--- a/src/kudu/tablet/ops/write_op.cc
+++ b/src/kudu/tablet/ops/write_op.cc
@@ -216,7 +216,7 @@ Status WriteOp::Prepare() {
replicate_msg()->write_request().auto_incrementing_column().auto_incrementing_counter());
}
}
- s = tablet->DecodeWriteOperations(&client_schema, state(), is_leader);
+ s = tablet->DecodeWriteOperations(&client_schema, state());
if (!s.ok()) {
// TODO(unknown): is MISMATCHED_SCHEMA always right here? probably not.
state()->completion_callback()->set_error(s,
TabletServerErrorPB::MISMATCHED_SCHEMA);
diff --git a/src/kudu/tablet/tablet.cc b/src/kudu/tablet/tablet.cc
index 7c17301fe..666f5a4f1 100644
--- a/src/kudu/tablet/tablet.cc
+++ b/src/kudu/tablet/tablet.cc
@@ -649,8 +649,7 @@ Status Tablet::NewRowIterator(RowIteratorOptions opts,
}
Status Tablet::DecodeWriteOperations(const Schema* client_schema,
- WriteOpState* op_state,
- bool is_leader) {
+ WriteOpState* op_state) {
TRACE_EVENT0("tablet", "Tablet::DecodeWriteOperations");
DCHECK(op_state->row_ops().empty());
diff --git a/src/kudu/tablet/tablet.h b/src/kudu/tablet/tablet.h
index 04c213955..63fe284d0 100644
--- a/src/kudu/tablet/tablet.h
+++ b/src/kudu/tablet/tablet.h
@@ -164,8 +164,7 @@ class Tablet {
// Decode the Write (insert/mutate) operations from within a user's
// request.
Status DecodeWriteOperations(const Schema* client_schema,
- WriteOpState* op_state,
- bool is_leader = false);
+ WriteOpState* op_state);
// Acquire locks for each of the operations in the given write op.
// This also sets the row op's RowSetKeyProbe.
