(kudu) branch master updated: [tablet] NewReplicaOpDriver() --> NewFollowerOpDriver()

[alexey]

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 2efdd37ba [tablet] NewReplicaOpDriver() --> NewFollowerOpDriver()
2efdd37ba is described below

commit 2efdd37ba8491ac0f55a5f4eaaf2960c62c102ba
Author: Alexey Serbin <ale...@apache.org>
AuthorDate: Thu Nov 16 20:43:53 2023 -0800

    [tablet] NewReplicaOpDriver() --> NewFollowerOpDriver()
    
    This patch renames the NewReplicaOpDriver() method in the TabletReplica
    class into NewFollowerOpDriver(), so it's easier to comprehend given
    there is the pairing NewLeaderOpDriver() method.  That's a better name
    if taking into account the terminology used throughout the project,
    where a tablet has a leader and follower replicas in the sense of the
    Raft protocol.
    
    This patch doesn't contain any functional modifications.
    
    Change-Id: I20fd90290b993ef777b017e44a36383b7f69adab
    Reviewed-on: http://gerrit.cloudera.org:8080/20713
    Reviewed-by: Mahesh Reddy <mre...@cloudera.com>
    Tested-by: Alexey Serbin <ale...@apache.org>
    Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
---
 src/kudu/tablet/tablet_replica.cc | 6 +++---
 src/kudu/tablet/tablet_replica.h  | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/kudu/tablet/tablet_replica.cc 
b/src/kudu/tablet/tablet_replica.cc
index a5fe99a5d..0536580c0 100644
--- a/src/kudu/tablet/tablet_replica.cc
+++ b/src/kudu/tablet/tablet_replica.cc
@@ -849,7 +849,7 @@ Status TabletReplica::StartFollowerOp(const 
scoped_refptr<ConsensusRound>& round
   state->set_consensus_round(round);
 
   scoped_refptr<OpDriver> driver;
-  RETURN_NOT_OK(NewReplicaOpDriver(std::move(op), &driver));
+  RETURN_NOT_OK(NewFollowerOpDriver(std::move(op), &driver));
 
   // A raw pointer is required to avoid a refcount cycle.
   auto* driver_raw = driver.get();
@@ -915,8 +915,8 @@ Status TabletReplica::NewLeaderOpDriver(unique_ptr<Op> op,
   return Status::OK();
 }
 
-Status TabletReplica::NewReplicaOpDriver(unique_ptr<Op> op,
-                                                  scoped_refptr<OpDriver>* 
driver) {
+Status TabletReplica::NewFollowerOpDriver(unique_ptr<Op> op,
+                                          scoped_refptr<OpDriver>* driver) {
   scoped_refptr<OpDriver> op_driver = new OpDriver(
     &op_tracker_,
     consensus_.get(),
diff --git a/src/kudu/tablet/tablet_replica.h b/src/kudu/tablet/tablet_replica.h
index 1e272fec9..9ce803641 100644
--- a/src/kudu/tablet/tablet_replica.h
+++ b/src/kudu/tablet/tablet_replica.h
@@ -319,8 +319,8 @@ class TabletReplica : public 
RefCountedThreadSafe<TabletReplica>,
                            scoped_refptr<OpDriver>* driver,
                            MonoTime deadline);
 
-  Status NewReplicaOpDriver(std::unique_ptr<Op> op,
-                            scoped_refptr<OpDriver>* driver);
+  Status NewFollowerOpDriver(std::unique_ptr<Op> op,
+                             scoped_refptr<OpDriver>* driver);
 
   // Tells the tablet's log to garbage collect.
   Status RunLogGC();