This is an automated email from the ASF dual-hosted git repository.
achennaka pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new 89b7a080c [docs] updated info on the C++ standard used in Kudu code
89b7a080c is described below
commit 89b7a080c023cac337af7e957e663885d86014f4
Author: Alexey Serbin <[email protected]>
AuthorDate: Thu Jan 4 12:25:26 2024 -0800
[docs] updated info on the C++ standard used in Kudu code
The Apache Kudu project has switched to using the C++-17 standard a long
time ago, so it's time to update the corresponding paragraph in the
documentation.
Change-Id: I51112c8e9fbc189da7b48526414af28bdcf29af9
Reviewed-on: http://gerrit.cloudera.org:8080/20859
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <[email protected]>
---
docs/contributing.adoc | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/docs/contributing.adoc b/docs/contributing.adoc
index a63840945..2e0c8687f 100644
--- a/docs/contributing.adoc
+++ b/docs/contributing.adoc
@@ -210,15 +210,16 @@ git commit -a --amend
Kudu's code base makes the following notable exceptions from the Google Style
Guide
referenced above:
-==== Notes on {cpp} 11
+==== Notes on {cpp}-17
-Kudu uses {cpp} 11. Check out this handy guide to {cpp} 11 move semantics and
rvalue
-references: https://www.chromium.org/rvalue-references
+Kudu code uses the {cpp}-17 standard internally, but Kudu {cpp} client API
+is still kept compatible with {cpp}-98.
-We aim to follow most of the same guidelines, such as, where possible,
migrating
-away from `foo.Pass()` in favor of `std::move(foo)`.
+Usage of the moving semantics (introduced in {cpp}-11) is encouraged. Check out
+this handy guide to move semantics and rvalue
+references: https://www.chromium.org/rvalue-references
-==== Limitations on `boost` Use
+==== Limitations on `boost` library usage
`boost` classes from header-only libraries can be used in cases where a
suitable
replacement does not exist in the Kudu code base. However:
