This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new 0d95304fa [tserver] fix typo in generating name of tablet copy pool
0d95304fa is described below
commit 0d95304fa46ee5d96bcaa934c7660369f2860e06
Author: Alexey Serbin <[email protected]>
AuthorDate: Mon Apr 29 23:10:11 2024 -0700
[tserver] fix typo in generating name of tablet copy pool
Don't use std::string instance after calling std::move() on it:
even if it's in valid state, it's contents is unspecified, so
the result name for the thread pool isn't what it expected to be.
Change-Id: If7287fd1255e174482e81fdfc863f5f4140199d7
Reviewed-on: http://gerrit.cloudera.org:8080/21374
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
---
src/kudu/tserver/tablet_copy_client.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/tserver/tablet_copy_client.cc
b/src/kudu/tserver/tablet_copy_client.cc
index c9b949027..d5c114675 100644
--- a/src/kudu/tserver/tablet_copy_client.cc
+++ b/src/kudu/tserver/tablet_copy_client.cc
@@ -232,7 +232,7 @@ TabletCopyClient::TabletCopyClient(
if (dst_tablet_copy_metrics_) {
dst_tablet_copy_metrics_->open_client_sessions->Increment();
}
- CHECK_OK(ThreadPoolBuilder("tablet-download-pool-" + tablet_id)
+ CHECK_OK(ThreadPoolBuilder("tablet-download-pool-" + tablet_id_)
.set_max_threads(FLAGS_tablet_copy_download_threads_nums_per_session)
.set_min_threads(FLAGS_tablet_copy_download_threads_nums_per_session)
.Build(&tablet_download_pool_));