(kudu) branch master updated: Fix row_project codegen params noalias overflow

[alexey]

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new c485c8c3c Fix row_project codegen params noalias overflow
c485c8c3c is described below

commit c485c8c3cf4b76d8a55e2ec98e27803341285f75
Author: qhsong <s...@sqh.me>
AuthorDate: Tue May 30 20:22:27 2023 +0800

    Fix row_project codegen params noalias overflow
    
    function->addParamAttr is 0-based indexes, current row_project generator IR 
code is:
    `define i1 @ProjRead(i8* %src, %"class.kudu::RowBlockRow"* noalias %rbrow, 
%"class.kudu::Arena"* noalias %arena)`
    not same with before.
    
    Change-Id: I1dab7d46cff96ed1ebbd020584a066f04e6ca12a
    Reviewed-on: http://gerrit.cloudera.org:8080/19952
    Tested-by: Kudu Jenkins
    Reviewed-by: Alexey Serbin <ale...@apache.org>
---
 src/kudu/codegen/row_projector.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/kudu/codegen/row_projector.cc 
b/src/kudu/codegen/row_projector.cc
index 90670df68..0949a1b70 100644
--- a/src/kudu/codegen/row_projector.cc
+++ b/src/kudu/codegen/row_projector.cc
@@ -118,10 +118,9 @@ llvm::Function* MakeProjection(const string& name,
 
   // Mark our arguments as not aliasing. This eliminates a redundant
   // load of rbrow->row_block_ and rbrow->row_index_ for each column.
-  // Note that these arguments are 1-based indexes.
+  f->addParamAttr(0, llvm::Attribute::NoAlias);
   f->addParamAttr(1, llvm::Attribute::NoAlias);
   f->addParamAttr(2, llvm::Attribute::NoAlias);
-  f->addParamAttr(3, llvm::Attribute::NoAlias);
 
   // Project row function in IR (note: values in angle brackets are
   // constants whose values are determined right now, at JIT time).