This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch branch-1.17.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/branch-1.17.x by this push:
new c2e7ddd61 [tests] fix a misprint
c2e7ddd61 is described below
commit c2e7ddd611687ae6be900f805ca760bba3fece57
Author: Alexey Serbin <[email protected]>
AuthorDate: Mon Apr 1 19:40:38 2024 -0700
[tests] fix a misprint
Tests should use ASSERT_NE(), not DCHECK_NE().
This is a follow-up to e54c80cf9ba129b943eed6af3266899753b1b4ac.
P.S.
This also fixes C++ build on macOS 14.5 for this 1.17.x branch with
Xcode 15.3. There was a linker error like below without this patch:
Undefined symbols for architecture x86_64:
"void
google::MakeCheckOpValueString<std::nullptr_t>(std::__1::basic_ostream<char,
std::__1::char_traits<char>>*, std::nullptr_t const&)", referenced from:
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>* google::MakeCheckOpString<std::nullptr_t,
kudu::cluster::ExternalTabletServer*>(std::nullptr_t const&,
kudu::cluster::ExternalTabletServer* const&, char const*) in
disk_reservation-itest.cc.o
ld: symbol(s) not found for architecture x86_64
Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Reviewed-on: http://gerrit.cloudera.org:8080/21229
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Mahesh Reddy <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
(cherry picked from commit ab368443d276006e93370a5b6bd5862eea2475fe)
Reviewed-on: http://gerrit.cloudera.org:8080/21919
Tested-by: Abhishek Chennaka <[email protected]>
---
src/kudu/integration-tests/disk_reservation-itest.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/integration-tests/disk_reservation-itest.cc
b/src/kudu/integration-tests/disk_reservation-itest.cc
index 519a2dfa7..d7e8dad01 100644
--- a/src/kudu/integration-tests/disk_reservation-itest.cc
+++ b/src/kudu/integration-tests/disk_reservation-itest.cc
@@ -177,7 +177,7 @@ TEST_F(DiskReservationITest, AvailableSpaceMetrics) {
NO_FATALS(StartCluster(ts_flags, {}, 1));
auto* ts = cluster_->tablet_server(0);
- DCHECK_NE(nullptr, ts);
+ ASSERT_NE(nullptr, ts);
const auto& addr = ts->bound_http_hostport();
auto space_getter_data_dirs = [&](int64_t* available_bytes) {
