This is an automated email from the ASF dual-hosted git repository. alexey pushed a commit to branch branch-1.18.x in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 155882b4f43f962e604ae18624db328e1263e1d3 Author: Alexey Serbin <[email protected]> AuthorDate: Wed Oct 16 11:01:07 2024 -0700 [dynamic_multi_master-test] add SKIP_IF_SLOW_NOT_ALLOWED This patch adds SKIP_IF_SLOW_NOT_ALLOWED() macro into appropriate scenarios in the dynamic_multi_master-test. The criteria to tag a scenario as 'slow' was the evidence of requiring more than 3 seconds to complete on a more-or-less contemporary machine (DEBUG build). The motivation for this changelist is to address the review feedback for one of the prior patches [1]. [1] review URL: http://gerrit.cloudera.org:8080/21935 gerrit ID : Id0f0005b8f3384ad05eee6bf65e17a0e4ed289f1 git hash : dbb6d5320ad60016355d0c63b6dae1650ba4e414 Change-Id: Ib255caf1ae33ebf9df9e71d9ea784d6e7d350ed9 Reviewed-on: http://gerrit.cloudera.org:8080/21943 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Marton Greber <[email protected]> (cherry picked from commit e0c7a37b9ded1b0052487a05fc6a65a8cb0efbbd) Reviewed-on: http://gerrit.cloudera.org:8080/22003 Reviewed-by: Abhishek Chennaka <[email protected]> --- src/kudu/master/dynamic_multi_master-test.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/kudu/master/dynamic_multi_master-test.cc b/src/kudu/master/dynamic_multi_master-test.cc index beb825789..d3c9e0a55 100644 --- a/src/kudu/master/dynamic_multi_master-test.cc +++ b/src/kudu/master/dynamic_multi_master-test.cc @@ -916,6 +916,8 @@ INSTANTIATE_TEST_SUITE_P(, ParameterizedRemoveMasterTest, // Tests removing a non-leader master from the cluster. TEST_P(ParameterizedRemoveMasterTest, TestRemoveMaster) { + SKIP_IF_SLOW_NOT_ALLOWED(); + NO_FATALS(StartCluster({// Keeping RPC timeouts short to quickly detect downed servers. // This will put the health status into an UNKNOWN state until the point // where they are considered FAILED. @@ -1186,6 +1188,8 @@ TEST_F(DynamicMultiMasterTest, TestRemoveMasterFeatureFlagNotSpecified) { // Test that attempts to request a non-leader master to add a new master. TEST_F(DynamicMultiMasterTest, TestAddMasterToNonLeader) { + SKIP_IF_SLOW_NOT_ALLOWED(); + NO_FATALS(SetUpWithNumMasters(2)); NO_FATALS(StartCluster()); @@ -1225,6 +1229,8 @@ TEST_F(DynamicMultiMasterTest, TestAddMasterToNonLeader) { // Test that attempts to request a non-leader master to remove a master. TEST_F(DynamicMultiMasterTest, TestRemoveMasterToNonLeader) { + SKIP_IF_SLOW_NOT_ALLOWED(); + NO_FATALS(SetUpWithNumMasters(2)); NO_FATALS(StartCluster()); @@ -1295,6 +1301,8 @@ TEST_F(DynamicMultiMasterTest, TestAddMasterMissingAndIncorrectAddress) { // Test that attempts to remove a master with missing master address and a non-existent // hostname. TEST_F(DynamicMultiMasterTest, TestRemoveMasterMissingAndIncorrectHostname) { + SKIP_IF_SLOW_NOT_ALLOWED(); + NO_FATALS(SetUpWithNumMasters(2)); NO_FATALS(StartCluster()); @@ -1533,6 +1541,8 @@ TEST_F(AutoAddMasterTest, TestSomeMastersUnreachable) { // Test if we fail to replicate the AddMaster request. TEST_F(AutoAddMasterTest, TestFailWithoutReplicatingAddMaster) { + SKIP_IF_SLOW_NOT_ALLOWED(); + // Make master followers unable to accept updates, including config changes. // We'll set this for all masters including leaders for simplicity. for (int i = 0; i < cluster_->num_masters(); i++) { @@ -1795,6 +1805,8 @@ class ParameterizedAutoAddMasterTest : public AutoAddMasterTest, }; TEST_P(ParameterizedAutoAddMasterTest, TestBasicAddition) { + SKIP_IF_SLOW_NOT_ALLOWED(); + TestWorkload w(cluster_.get()); w.set_num_replicas(1); // Using one thread and injecting delays between write batches to reduce
