This is an automated email from the ASF dual-hosted git repository. alexey pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit f6fdddd1c934183ffbc308ab753c045093390ad0 Author: Ádám Bakai <[email protected]> AuthorDate: Tue Nov 19 15:06:08 2024 +0100 [fs_manager-test] Decrease attempts for logr Logr uses RocksDB and opening RocksDB instances takes significantly longer than lbm. So the number of attempts was reduced in FsManagerTestBase::TestAddRemoveDataDirsFuzz to decrease the test's runtime. Change-Id: If0bb9735467071f9bc00e7b61c61cd71a47bb812 Reviewed-on: http://gerrit.cloudera.org:8080/22078 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> Reviewed-by: Attila Bukor <[email protected]> --- src/kudu/fs/fs_manager-test.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/kudu/fs/fs_manager-test.cc b/src/kudu/fs/fs_manager-test.cc index b3c0cba71..3ab3e2fa8 100644 --- a/src/kudu/fs/fs_manager-test.cc +++ b/src/kudu/fs/fs_manager-test.cc @@ -1261,10 +1261,11 @@ TEST_P(FsManagerTestBase, TestAddRemoveDataDirsFuzz) { // When using a sanitizer, reduce the loop times to get a more stable result. const int kNumAttempts = 10; #else - // In some situations, the tests would last too long time, so we reduce the loop times if not - // AllowSlowTests(). For example, when FLAGS_block_manager == "logr", opens a data directory will - // open a RocksDB instance, it consumes more time than that if FLAGS_block_manager == "log". - const int kNumAttempts = AllowSlowTests() ? 1000 : 10; + // In some situations, the tests would take too long, so we reduce number of times the loop + // runs if slow tests are not allowed. Since logr will open multiple RocksDB instances and it + // takes longer than log block manager, it will only run the loop 100 times if slow + // tests are allowed. + const int kNumAttempts = AllowSlowTests() ? (FLAGS_block_manager == "logr" ? 100 : 1000) : 10; #endif Random rng_(SeedRandom());
