This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch branch-1.18.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/branch-1.18.x by this push:
new 6724e9b53 [thirdparty] strip unnecessary features from libcurl
6724e9b53 is described below
commit 6724e9b5343b7b85da30c547c150289418db10c2
Author: Alexey Serbin <[email protected]>
AuthorDate: Fri Dec 13 12:07:32 2024 -0800
[thirdparty] strip unnecessary features from libcurl
Prior to this patch, running `./curl -V` from
$KUDU_HOME/thirdparty/installed/uninstrumented/bin would report on a few
built-in features not used in Kudu. This patch adds explicit flags
for the configure script to build only the necessities and avoid
building anything that's not used in Kudu.
Change-Id: I9aecf7fb69f0f0be1e78bc9e852dbe83a901df2a
Reviewed-on: http://gerrit.cloudera.org:8080/22213
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <[email protected]>
(cherry picked from commit 2baf2ed85f71dd3fe0d1cc4aafcb7d9dcb7f716c)
Reviewed-on: http://gerrit.cloudera.org:8080/22219
---
thirdparty/build-definitions.sh | 28 +++++++++++++++++++++++++---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index 000a3444f..c488d49c4 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -751,9 +751,7 @@ build_curl() {
# In the scope of using libcurl in Kudu tests and other simple scenarios,
# not so much functionality is needed as of now, so configure for a fairly
# minimal install. For testing, we need HTTP/HTTPS with GSSAPI support
- # (GSSAPI is needed for SPNEGO testing). Also, cookies might be useful
- # to test the new functionality introduced in Impala's embedded Web server
- # recently if Kudu is to pick up the new functionality as well.
+ # (GSSAPI is needed for SPNEGO testing).
#
# NOTE: curl shows a message asking for CPPFLAGS to be used for include
# directories, not CFLAGS.
@@ -765,11 +763,17 @@ build_curl() {
$CURL_SOURCE/configure \
--prefix=$PREFIX \
--disable-alt-svc \
+ --disable-aws \
+ --disable-cookies \
+ --disable-dateparse \
--disable-dict \
--disable-docs \
--disable-doh \
--disable-file \
+ --disable-form-api \
--disable-ftp \
+ --disable-headers-api \
+ --disable-hsts \
--disable-httpsrr \
--disable-gopher \
--disable-imap \
@@ -780,25 +784,43 @@ build_curl() {
--disable-libcurl-option \
--disable-manual \
--disable-mime \
+ --disable-mqtt \
--disable-netrc \
+ --disable-ntlm \
--disable-pop3 \
--disable-progress-meter \
--disable-rtsp \
--disable-sha512-256 \
--disable-smb \
--disable-smtp \
+ --disable-sspi \
--disable-telnet \
--disable-tftp \
+ --disable-tls-srp \
+ --disable-unix-sockets \
--disable-websockets \
+ --enable-basic-auth \
+ --enable-bearer-auth \
+ --enable-digest-auth \
+ --enable-http-auth \
+ --enable-kerberos-auth \
+ --enable-negotiate-auth \
--without-apple-idn \
--without-brotli \
+ --without-fish-functions-dir \
--without-libidn2 \
--without-libpsl \
--without-librtmp \
+ --without-libssh \
--without-libssh2 \
--without-libuv \
+ --without-msh3 \
--without-nghttp2 \
+ --without-nghttp3 \
+ --without-ngtcp2 \
--without-openssl-quic \
+ --without-quiche \
+ --without-zsh-functions-dir \
--without-zstd \
--with-gssapi \
--with-openssl