This is an automated email from the ASF dual-hosted git repository. alexey pushed a commit to branch branch-1.18.x in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 5ce055a6b4ea6f8b8bd7a843178fe7113b2d6caa Author: Alexey Serbin <[email protected]> AuthorDate: Thu Jan 30 16:42:48 2025 -0800 [maintenance_manager] micro-optimisation on LogPrefix There is just a single instance of MaintenanceManager per Kudu server, so it makes sense to store its log prefix as a field and avoid allocating memory and constructing the string every time a log message is issued. This patch doesn't contain any functional modifications. Change-Id: I40398106af386eb352cef05df7644941a230a468 Reviewed-on: http://gerrit.cloudera.org:8080/22428 Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> (cherry picked from commit 691c3e68ecf58c83cbb5fc5448fc2d7a51196311) Reviewed-on: http://gerrit.cloudera.org:8080/22439 --- src/kudu/util/maintenance_manager.cc | 5 +---- src/kudu/util/maintenance_manager.h | 5 ++++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/kudu/util/maintenance_manager.cc b/src/kudu/util/maintenance_manager.cc index 2fbfbb032..ac2ac9067 100644 --- a/src/kudu/util/maintenance_manager.cc +++ b/src/kudu/util/maintenance_manager.cc @@ -203,6 +203,7 @@ MaintenanceManager::MaintenanceManager( string server_uuid, const scoped_refptr<MetricEntity>& metric_entity) : server_uuid_(std::move(server_uuid)), + log_prefix_(Substitute("P $0: ", server_uuid_)), num_threads_(options.num_threads > 0 ? options.num_threads : FLAGS_maintenance_manager_num_threads), @@ -697,10 +698,6 @@ void MaintenanceManager::GetMaintenanceManagerStatusDump( } } -string MaintenanceManager::LogPrefix() const { - return Substitute("P $0: ", server_uuid_); -} - bool MaintenanceManager::HasFreeThreads() { return num_threads_ > running_ops_; } diff --git a/src/kudu/util/maintenance_manager.h b/src/kudu/util/maintenance_manager.h index bc9a9b7d3..819b328c4 100644 --- a/src/kudu/util/maintenance_manager.h +++ b/src/kudu/util/maintenance_manager.h @@ -362,7 +362,9 @@ class MaintenanceManager : public std::enable_shared_from_this<MaintenanceManage void LaunchOp(MaintenanceOp* op); - std::string LogPrefix() const; + const std::string& LogPrefix() const { + return log_prefix_; + } bool HasFreeThreads(); @@ -385,6 +387,7 @@ class MaintenanceManager : public std::enable_shared_from_this<MaintenanceManage bool ProceedWithFlush(double* used_memory_percentage); const std::string server_uuid_; + const std::string log_prefix_; const int32_t num_threads_; const MonoDelta polling_interval_;
