This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new 0e12e37be KUDU-1261 show 'enable_array_columns' with 'kudu perf
loadgen' help
0e12e37be is described below
commit 0e12e37be270279f87216c15b66b948d54792710
Author: Alexey Serbin <[email protected]>
AuthorDate: Thu Oct 16 16:38:33 2025 -0700
KUDU-1261 show 'enable_array_columns' with 'kudu perf loadgen' help
This changelist adds usage-style help for the new flag introduced with
03d7cb4ea into the 'kudu perf loadgen' CLI tool.
I also updated the corresponding test scenario to make sure all the
registered flags are output with 'kudu perf loadgen --help' command.
This is a follow-up to 03d7cb4ea285efbaa942194670a72516e041bcf2.
Change-Id: Ifccb473f195ffa120edca7d039944c3aa68adc71
Reviewed-on: http://gerrit.cloudera.org:8080/23555
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
---
src/kudu/tools/kudu-tool-test.cc | 32 ++++++++++++++++++++++++++++++++
src/kudu/tools/tool_action_perf.cc | 5 +++--
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/src/kudu/tools/kudu-tool-test.cc b/src/kudu/tools/kudu-tool-test.cc
index 834de1491..f674a7089 100644
--- a/src/kudu/tools/kudu-tool-test.cc
+++ b/src/kudu/tools/kudu-tool-test.cc
@@ -1591,6 +1591,38 @@ TEST_F(ToolTest, TestModeHelp) {
};
NO_FATALS(RunTestHelp(kCmd, kPerfRegexes));
NO_FATALS(RunTestHelpRpcFlags(kCmd, {"loadgen", "table_scan"}));
+
+ const vector<string> kLoadgenHelpRegexes = {
+ "-auto_database.*The database in which to create the automatically
generated",
+ "-buffer_flush_watermark_pct.*Mutation buffer flush watermark",
+ "-buffer_size_bytes.*Size of the mutation buffer, per session",
+ "-buffers_num.*Number of mutation buffers per session",
+ "-enable_array_columns.*Whether to add and populate with data",
+ "-error_buffer_size_bytes.*Size of the error buffer, per session",
+ "-flush_per_n_rows.*Perform async flush per given number of rows added",
+ "-keep_auto_table.*If using the auto-generated table",
+ "-num_rows_per_thread.*Number of rows each thread generates and inserts",
+ "-num_threads.*Number of threads to run",
+ "-run_cleanup.*Whether to run post-insertion deletion",
+ "-run_scan.*Whether to run post-insertion scan",
+ "-seq_start.*Initial value for the generator in sequential mode",
+ "-show_first_n_errors.*Output detailed information",
+ "-string_fixed.*Pre-defined string to write",
+ "-string_len.*Length of strings to put into string and binary columns",
+ "-table_name.*Name of an existing table to use for the test",
+ "-table_num_hash_partitions.*The number of hash partitions to create",
+ "-table_num_range_partitions.*The number of range partitions to create",
+ "-table_num_replicas.*The number of replicas for the auto-created table",
+ "-txn_start.*Whether the generated rows are inserted",
+ "-txn_commit.*Whether to commit the multi-row transaction",
+ "-txn_rollback.*Whether to rollback the multi-row transaction",
+ "-use_client_per_thread.*Use a separate KuduClient instance",
+ "-use_random.*Whether to use random numbers",
+ "-use_random_pk.*Whether to use random numbers",
+ "-use_random_non_pk.*Whether to use random numbers",
+ "-use_upsert.*Whether to use UPSERT instead of INSERT",
+ };
+ NO_FATALS(RunTestHelp("perf loadgen --help", kLoadgenHelpRegexes));
}
{
const string kCmd = "remote_replica";
diff --git a/src/kudu/tools/tool_action_perf.cc
b/src/kudu/tools/tool_action_perf.cc
index e4810fcb0..1a8829f13 100644
--- a/src/kudu/tools/tool_action_perf.cc
+++ b/src/kudu/tools/tool_action_perf.cc
@@ -390,8 +390,8 @@ DEFINE_bool(txn_rollback, false,
DEFINE_bool(enable_array_columns, false,
"Whether to add and populate with data array data type columns "
"in the automatically created table (a.k.a. auto-table): "
- "'arr_int64' (INT64 1D array) and 'arr_string' (STRING 1D array) "
- "columns. If array columns are present in already existing table "
+ "'arr_int64' (INT64 1D array) and 'arr_string' (STRING 1D array). "
+ "If array columns are present in already existing table "
"specified by the --table_name flag, the tool populates such "
"columns regardless of this flag's setting.");
@@ -1177,6 +1177,7 @@ unique_ptr<Mode> BuildPerfMode() {
.AddOptionalParameter("buffer_flush_watermark_pct")
.AddOptionalParameter("buffer_size_bytes")
.AddOptionalParameter("buffers_num")
+ .AddOptionalParameter("enable_array_columns")
.AddOptionalParameter("error_buffer_size_bytes")
.AddOptionalParameter("flush_per_n_rows")
.AddOptionalParameter("keep_auto_table")
