This is an automated email from the ASF dual-hosted git repository.

mgreber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit ededf25e8d1970d0bafed7b645781d269b2db63c
Author: Alexey Serbin <[email protected]>
AuthorDate: Mon Oct 6 21:43:30 2025 -0700

    [thirdparty] explicit include directive for gumbo-query
    
    There were reports that building Kudu as a part of Impala's toolchain
    on Ubuntu 24.04 LTS would fail on compiling gumbo-query because the
    necessary include directory directive -I$PREFIX/include was not added
    by CMake, while it should have been present.  Getting to the bottom
    of the issue might be time-consuming, but adding the include directory
    explicitly is easy and shouldn't hurt since we already do so when
    building glog at least.
    
    Change-Id: I65b8a6d3b63ff6684e2ed8579b01f25c243ffc66
    Reviewed-on: http://gerrit.cloudera.org:8080/23501
    Reviewed-by: Marton Greber <[email protected]>
    Tested-by: Marton Greber <[email protected]>
    Reviewed-by: Gabriella Lotz <[email protected]>
---
 thirdparty/build-definitions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index 24cc156aa..057a612af 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -1187,7 +1187,7 @@ build_gumbo_query() {
   cmake \
     -DCMAKE_BUILD_TYPE=release \
     -DCMAKE_INSTALL_PREFIX=$PREFIX \
-    -DCMAKE_CXX_FLAGS="$EXTRA_CXXFLAGS" \
+    -DCMAKE_CXX_FLAGS="$EXTRA_CXXFLAGS -I$PREFIX/include" \
     -DCMAKE_EXE_LINKER_FLAGS="$EXTRA_LDFLAGS $EXTRA_LIBS" \
     -DCMAKE_MODULE_LINKER_FLAGS="$EXTRA_LDFLAGS $EXTRA_LIBS" \
     -DCMAKE_SHARED_LINKER_FLAGS="$EXTRA_LDFLAGS $EXTRA_LIBS -L$PREFIX/lib 
-Wl,-rpath,$PREFIX/lib" \

Reply via email to