This is an automated email from the ASF dual-hosted git repository.
achennaka pushed a commit to branch branch-1.18.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/branch-1.18.x by this push:
new 651628366 [thirdparty] explicit include directive for gumbo-query
651628366 is described below
commit 65162836649cf455923ade5654bafcff100a63a5
Author: Alexey Serbin <[email protected]>
AuthorDate: Mon Oct 6 21:43:30 2025 -0700
[thirdparty] explicit include directive for gumbo-query
There were reports that building Kudu as a part of Impala's toolchain
on Ubuntu 24.04 LTS would fail on compiling gumbo-query because the
necessary include directory directive -I$PREFIX/include was not added
by CMake, while it should have been present. Getting to the bottom
of the issue might be time-consuming, but adding the include directory
explicitly is easy and shouldn't hurt since we already do so when
building glog at least.
Change-Id: I65b8a6d3b63ff6684e2ed8579b01f25c243ffc66
Reviewed-on: http://gerrit.cloudera.org:8080/23501
Reviewed-by: Marton Greber <[email protected]>
Tested-by: Marton Greber <[email protected]>
Reviewed-by: Gabriella Lotz <[email protected]>
(cherry picked from commit ededf25e8d1970d0bafed7b645781d269b2db63c)
Reviewed-on: http://gerrit.cloudera.org:8080/23502
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Abhishek Chennaka <[email protected]>
---
thirdparty/build-definitions.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index 9bfe8ff7e..0608758ed 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -1163,7 +1163,7 @@ build_gumbo_query() {
cmake \
-DCMAKE_BUILD_TYPE=release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
- -DCMAKE_CXX_FLAGS="$EXTRA_CXXFLAGS" \
+ -DCMAKE_CXX_FLAGS="$EXTRA_CXXFLAGS -I$PREFIX/include" \
-DCMAKE_EXE_LINKER_FLAGS="$EXTRA_LDFLAGS $EXTRA_LIBS" \
-DCMAKE_MODULE_LINKER_FLAGS="$EXTRA_LDFLAGS $EXTRA_LIBS" \
-DCMAKE_SHARED_LINKER_FLAGS="$EXTRA_LDFLAGS $EXTRA_LIBS -L$PREFIX/lib
-Wl,-rpath,$PREFIX/lib" \
