(kudu) branch branch-1.18.x updated: [codegen] fix build on macOS

[mgreber]

This is an automated email from the ASF dual-hosted git repository.

mgreber pushed a commit to branch branch-1.18.x
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/branch-1.18.x by this push:
     new a598aab90 [codegen] fix build on macOS
a598aab90 is described below

commit a598aab90d903dcc1383cc05419328f5bd3fdd69
Author: Alexey Serbin <ale...@apache.org>
AuthorDate: Wed Feb 4 16:27:41 2026 -0800

    [codegen] fix build on macOS
    
    This addresses linker error on macOS:
    
        void google::MakeCheckOpValueString<std::nullptr_t>(...), referenced 
from:
            ... google::MakeCheckOpString<std::nullptr_t, void*>(...) in 
jit_frame_manager.cc.o
      ld: symbol(s) not found for architecture x86_64
    
    This is a follow-up to 0efbebd487e7d0c7f21ab0d5a91e0fa70046af83.
    
    Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
    Reviewed-on: http://gerrit.cloudera.org:8080/23943
    Tested-by: Alexey Serbin <ale...@apache.org>
    Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
    Reviewed-by: Marton Greber <greber...@gmail.com>
    Reviewed-by: Zoltan Martonka <zmarto...@cloudera.com>
    Reviewed-by: Zoltan Chovan <zcho...@cloudera.com>
    (cherry picked from commit 514a3ff1a3b0ed912498a079ba73c7afcdd1a753)
    Reviewed-on: http://gerrit.cloudera.org:8080/23961
---
 src/kudu/codegen/jit_frame_manager.cc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/kudu/codegen/jit_frame_manager.cc 
b/src/kudu/codegen/jit_frame_manager.cc
index e230cfa93..d9af5483a 100644
--- a/src/kudu/codegen/jit_frame_manager.cc
+++ b/src/kudu/codegen/jit_frame_manager.cc
@@ -96,7 +96,6 @@ MemoryBlock 
JITFrameManager::CustomMapper::allocateMappedMemory(
                                : 0;
   int mm_flags = MAP_PRIVATE | MAP_ANON;
   if (!is_pre_allocation) {
-    DCHECK_NE(0, start);
     mm_flags |= MAP_FIXED;
   }
 
@@ -202,7 +201,7 @@ std::error_code 
JITFrameManager::CustomMapper::protectMappedMemory(
 void JITFrameManager::CustomMapper::setPreAllocatedRange(
     const llvm::sys::MemoryBlock& range) {
   // This should be called at most once per CustomMapper instance.
-  DCHECK_EQ(nullptr, memory_range_.base());
+  DCHECK(!memory_range_.base());
   DCHECK_EQ(0, memory_range_.allocatedSize());
   memory_range_ = range;
 
@@ -239,7 +238,7 @@ void JITFrameManager::reserveAllocationSpace(uintptr_t 
code_size,
                                              uintptr_t rw_data_size,
                                              uint32_t rw_data_align) {
   // This can be called only once per JITFrameManager instance.
-  DCHECK_EQ(nullptr, preallocated_block_.base());
+  DCHECK(!preallocated_block_.base());
   DCHECK_EQ(0, preallocated_block_.allocatedSize());
 
   DCHECK_NE(0, code_align);
@@ -289,7 +288,7 @@ void JITFrameManager::reserveAllocationSpace(uintptr_t 
code_size,
     // JITFrameManager instance to allocate memory for the sections of the
     // jitted object being loaded, the memory for each section is allocated
     // strictly within the reserved memory area.
-    DCHECK_NE(nullptr, preallocated_block_.base());
+    DCHECK(preallocated_block_.base());
     DCHECK_NE(0, preallocated_block_.allocatedSize());
     setNearHintMB(MemoryBlock(preallocated_block_.base(), 0));
     mm_->setPreAllocatedRange(preallocated_block_);