This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/incubator-kvrocks.git
The following commit(s) were added to refs/heads/unstable by this push:
new bda64ad Replace `text` with `universal_newlines` to support
python<3.7 in `x.py` (#789)
bda64ad is described below
commit bda64adc09f47f0bb19d4fcc85d69579f9ebcbc8
Author: Twice <[email protected]>
AuthorDate: Wed Aug 24 10:36:00 2022 +0800
Replace `text` with `universal_newlines` to support python<3.7 in `x.py`
(#789)
* Replace `text` with `universal_newlines` to support python<3.7 in `x.py`
* add python to README
---
README.md | 4 ++--
x.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/README.md b/README.md
index 6deb710..9f74eaf 100644
--- a/README.md
+++ b/README.md
@@ -69,11 +69,11 @@ Kvrocks has the following key features:
```shell
# CentOS / RedHat
sudo yum install -y epel-release
-sudo yum install -y git gcc gcc-c++ make cmake autoconf automake libtool
libstdc++-static
+sudo yum install -y git gcc gcc-c++ make cmake autoconf automake libtool
libstdc++-static python3
# Ubuntu / Debian
sudo apt update
-sudo apt install -y gcc g++ make cmake autoconf automake libtool
+sudo apt install -y git gcc g++ make cmake autoconf automake libtool python3
# macOS
brew install autoconf automake libtool cmake
diff --git a/x.py b/x.py
index 2a3eb7d..4e84a8c 100755
--- a/x.py
+++ b/x.py
@@ -67,7 +67,7 @@ def run(*args: str, msg: Optional[str]=None, verbose:
bool=False, **kwargs: Any)
return p
def run_pipe(*args: str, msg: Optional[str]=None, verbose: bool=False,
**kwargs: Any) -> TextIO:
- p = run(*args, msg=msg, verbose=verbose, stdout=PIPE, text=True, **kwargs)
+ p = run(*args, msg=msg, verbose=verbose, stdout=PIPE,
universal_newlines=True, **kwargs)
return p.stdout # type: ignore
def find_command(command: str, msg: Optional[str]=None) -> str:
