This is an automated email from the ASF dual-hosted git repository.

binbin pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git


The following commit(s) were added to refs/heads/unstable by this push:
     new 592b24fd Remove the no-script flag in the LASTSAVE command (#1708)
592b24fd is described below

commit 592b24fd39b58bf07af54162605bddcd5b531ba7
Author: Binbin <[email protected]>
AuthorDate: Tue Aug 29 12:25:21 2023 +0800

    Remove the no-script flag in the LASTSAVE command (#1708)
    
    Redis allow run it in the script:
    ```
    127.0.0.1:6379> eval "return redis.call('lastsave')" 0
    (integer) 1693277322
    ```
    
    Look like a copy-paste bug.
---
 src/commands/cmd_server.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/commands/cmd_server.cc b/src/commands/cmd_server.cc
index d9b972de..84c609c5 100644
--- a/src/commands/cmd_server.cc
+++ b/src/commands/cmd_server.cc
@@ -1093,7 +1093,7 @@ REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandAuth>("auth", 
2, "read-only ok-loadin
 
                         MakeCmdAttr<CommandCompact>("compact", 1, "read-only 
no-script", 0, 0, 0),
                         MakeCmdAttr<CommandBGSave>("bgsave", 1, "read-only 
no-script", 0, 0, 0),
-                        MakeCmdAttr<CommandLastSave>("lastsave", 1, "read-only 
no-script", 0, 0, 0),
+                        MakeCmdAttr<CommandLastSave>("lastsave", 1, 
"read-only", 0, 0, 0),
                         MakeCmdAttr<CommandFlushBackup>("flushbackup", 1, 
"read-only no-script", 0, 0, 0),
                         MakeCmdAttr<CommandSlaveOf>("slaveof", 3, "read-only 
exclusive no-script", 0, 0, 0),
                         MakeCmdAttr<CommandStats>("stats", 1, "read-only", 0, 
0, 0), )

Reply via email to