This is an automated email from the ASF dual-hosted git repository.
binbin pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git
The following commit(s) were added to refs/heads/unstable by this push:
new 9a79dd0f Change the default value of max-io-mb to 0 (unlimited) (#1713)
9a79dd0f is described below
commit 9a79dd0f1ab97b237e891737f6ad92cae418e2eb
Author: Binbin <[email protected]>
AuthorDate: Wed Aug 30 20:00:06 2023 +0800
Change the default value of max-io-mb to 0 (unlimited) (#1713)
For now, the max-io-mb is 500MiB which may be too low for fast devices
like NVMe SSD, so it'd be better to set the io bandwidth to unlimited by
default.
This closes #1711.
---
kvrocks.conf | 4 ++--
src/config/config.cc | 2 +-
utils/create-cluster/default.conf | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kvrocks.conf b/kvrocks.conf
index 781295ee..c61015cb 100644
--- a/kvrocks.conf
+++ b/kvrocks.conf
@@ -274,8 +274,8 @@ max-replication-mb 0
# The maximum allowed aggregated write rate of flush and compaction (in MB/s).
# If the rate exceeds max-io-mb, io will slow down.
# 0 is no limit
-# Default: 500
-max-io-mb 500
+# Default: 0
+max-io-mb 0
# The maximum allowed space (in GB) that should be used by RocksDB.
# If the total size of the SST files exceeds max_allowed_space, writes to
RocksDB will fail.
diff --git a/src/config/config.cc b/src/config/config.cc
index 815852e5..73b798ab 100644
--- a/src/config/config.cc
+++ b/src/config/config.cc
@@ -128,7 +128,7 @@ Config::Config() {
{"log-dir", true, new StringField(&log_dir, "")},
{"log-level", false, new EnumField(&log_level, log_levels,
google::INFO)},
{"pidfile", true, new StringField(&pidfile, "")},
- {"max-io-mb", false, new IntField(&max_io_mb, 500, 0, INT_MAX)},
+ {"max-io-mb", false, new IntField(&max_io_mb, 0, 0, INT_MAX)},
{"max-bitmap-to-string-mb", false, new
IntField(&max_bitmap_to_string_mb, 16, 0, INT_MAX)},
{"max-db-size", false, new IntField(&max_db_size, 0, 0, INT_MAX)},
{"max-replication-mb", false, new IntField(&max_replication_mb, 0, 0,
INT_MAX)},
diff --git a/utils/create-cluster/default.conf
b/utils/create-cluster/default.conf
index a8fa66f8..ad5e5ae4 100644
--- a/utils/create-cluster/default.conf
+++ b/utils/create-cluster/default.conf
@@ -11,6 +11,6 @@ slave-read-only yes
tcp-backlog 511
slave-serve-stale-data yes
max-replication-mb 0
-max-io-mb 500
+max-io-mb 0
max-db-size 0
cluster-enabled yes
