[kvrocks] branch unstable updated: Fix missing return value receiver when using slices.Compact (#1771)

[tison]

This is an automated email from the ASF dual-hosted git repository.

tison pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git


The following commit(s) were added to refs/heads/unstable by this push:
     new 49c62485 Fix missing return value receiver when using slices.Compact 
(#1771)
49c62485 is described below

commit 49c6248584f5bb23cb655960901ad8bb3910980b
Author: hulk <hulk.webs...@gmail.com>
AuthorDate: Wed Sep 20 22:53:27 2023 +0800

    Fix missing return value receiver when using slices.Compact (#1771)
---
 tests/gocase/unit/scan/scan_test.go | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/tests/gocase/unit/scan/scan_test.go 
b/tests/gocase/unit/scan/scan_test.go
index 439b3877..1e6488d7 100644
--- a/tests/gocase/unit/scan/scan_test.go
+++ b/tests/gocase/unit/scan/scan_test.go
@@ -48,7 +48,7 @@ func TestScanEmptyKey(t *testing.T) {
        keys, _, err := rdb.SScan(ctx, "sadd_key", 0, "*", 10000).Result()
        require.NoError(t, err)
        slices.Sort(keys)
-       slices.Compact(keys)
+       keys = slices.Compact(keys)
        require.Equal(t, []string{"", "fab", "fiz", "foobar"}, keys)
 }
 
@@ -77,7 +77,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                require.NoError(t, rdb.FlushDB(ctx).Err())
                util.Populate(t, rdb, "", 1000, 10)
                keys := scanAll(t, rdb)
-               slices.Compact(keys)
+               keys = slices.Compact(keys)
                require.Len(t, keys, 1000)
        })
 
@@ -85,7 +85,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                require.NoError(t, rdb.FlushDB(ctx).Err())
                util.Populate(t, rdb, "", 1000, 10)
                keys := scanAll(t, rdb, "count", 5)
-               slices.Compact(keys)
+               keys = slices.Compact(keys)
                require.Len(t, keys, 1000)
        })
 
@@ -93,7 +93,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                require.NoError(t, rdb.FlushDB(ctx).Err())
                util.Populate(t, rdb, "key:", 1000, 10)
                keys := scanAll(t, rdb, "match", "key:*")
-               slices.Compact(keys)
+               keys = slices.Compact(keys)
                require.Len(t, keys, 1000)
        })
 
@@ -127,7 +127,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                        }
                        originKeys = append(originKeys, key)
                }
-               slices.Compact(originKeys)
+               originKeys = slices.Compact(originKeys)
                require.Len(t, originKeys, 100)
        })
 
@@ -173,7 +173,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                keys, _, err := rdb.SScan(ctx, "mykey", 0, "foo*", 
10000).Result()
                require.NoError(t, err)
                slices.Sort(keys)
-               slices.Compact(keys)
+               keys = slices.Compact(keys)
                require.Equal(t, []string{"foo", "foobar"}, keys)
        })
 
@@ -183,7 +183,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                keys, _, err := rdb.HScan(ctx, "mykey", 0, "foo*", 
10000).Result()
                require.NoError(t, err)
                slices.Sort(keys)
-               slices.Compact(keys)
+               keys = slices.Compact(keys)
                require.Equal(t, []string{"1", "10", "foo", "foobar"}, keys)
        })
 
@@ -199,7 +199,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                keys, _, err := rdb.ZScan(ctx, "mykey", 0, "foo*", 
10000).Result()
                require.NoError(t, err)
                slices.Sort(keys)
-               slices.Compact(keys)
+               keys = slices.Compact(keys)
                require.Equal(t, []string{"1", "10", "foo", "foobar"}, keys)
        })
 
@@ -219,7 +219,7 @@ func ScanTest(t *testing.T, rdb *redis.Client, ctx 
context.Context) {
                        require.NoError(t, rdb.SAdd(ctx, "set", 
elements...).Err())
                        keys, _, err := rdb.SScan(ctx, "set", 0, "", 
10000).Result()
                        require.NoError(t, err)
-                       slices.Compact(keys)
+                       keys = slices.Compact(keys)
                        require.Len(t, keys, 100)
                })
        }