(kvrocks) branch unstable updated: Improve logging message for retryable background IO errors (#2317)

[twice]

This is an automated email from the ASF dual-hosted git repository.

twice pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git


The following commit(s) were added to refs/heads/unstable by this push:
     new 15d81f05 Improve logging message for retryable background IO errors 
(#2317)
15d81f05 is described below

commit 15d81f05b3dfb8b936dc54a6fe8bd1fd58960e67
Author: VasuDevrani <101383635+vasudevr...@users.noreply.github.com>
AuthorDate: Fri May 17 17:04:26 2024 +0530

    Improve logging message for retryable background IO errors (#2317)
    
    Co-authored-by: Twice <tw...@apache.org>
    Co-authored-by: Myth <caipen...@outlook.com>
---
 src/server/server.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/server/server.cc b/src/server/server.cc
index 0ebc142c..7ed970bf 100644
--- a/src/server/server.cc
+++ b/src/server/server.cc
@@ -808,8 +808,12 @@ void Server::cron() {
     // In order to properly handle all possible situations on rocksdb, we 
manually resume here
     // when encountering no space error and disk quota exceeded error.
     if (counter != 0 && counter % 600 == 0 && 
storage->IsDBInRetryableIOError()) {
-      storage->GetDB()->Resume();
-      LOG(INFO) << "[server] Schedule to resume DB after retryable IO error";
+      auto s = storage->GetDB()->Resume();
+      if (s.ok()) {
+        LOG(WARNING) << "[server] Successfully resumed DB after retryable IO 
error";
+      } else {
+        LOG(ERROR) << "[server] Failed to resume DB after retryable IO error: 
" << s.ToString();
+      }
       storage->SetDBInRetryableIOError(false);
     }