This is an automated email from the ASF dual-hosted git repository.

hulk pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git


The following commit(s) were added to refs/heads/unstable by this push:
     new 242d887b chore: remove the duplicate const error message (#2800)
242d887b is described below

commit 242d887ba767b850e070fa6ad0c103935d2ee4c9
Author: hulk <[email protected]>
AuthorDate: Sat Feb 22 16:30:46 2025 +0800

    chore: remove the duplicate const error message (#2800)
    
    Co-authored-by: Twice <[email protected]>
---
 src/cluster/replication.cc     | 2 +-
 src/commands/error_constants.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/cluster/replication.cc b/src/cluster/replication.cc
index b8d10907..78a0a02c 100644
--- a/src/cluster/replication.cc
+++ b/src/cluster/replication.cc
@@ -1039,7 +1039,7 @@ bool ReplicationThread::isRestoringError(std::string_view 
err) {
 
 bool ReplicationThread::isWrongPsyncNum(std::string_view err) {
   // err doesn't contain the CRLF, so cannot use redis::Error here.
-  return err == RESP_PREFIX_ERROR + 
redis::StatusToRedisErrorMsg({Status::NotOK, redis::errWrongNumArguments});
+  return err == RESP_PREFIX_ERROR + 
redis::StatusToRedisErrorMsg({Status::NotOK, redis::errWrongNumOfArguments});
 }
 
 bool ReplicationThread::isUnknownOption(std::string_view err) {
diff --git a/src/commands/error_constants.h b/src/commands/error_constants.h
index 713f31d0..fc33b60d 100644
--- a/src/commands/error_constants.h
+++ b/src/commands/error_constants.h
@@ -44,7 +44,5 @@ inline constexpr const char *errValueIsNotFloat = "value is 
not a valid float";
 inline constexpr const char *errNoMatchingScript = "No matching script. Please 
use EVAL";
 inline constexpr const char *errUnknownOption = "unknown option";
 inline constexpr const char *errUnknownSubcommandOrWrongArguments = "Unknown 
subcommand or wrong number of arguments";
-inline constexpr const char *errWrongNumArguments = "wrong number of 
arguments";
 inline constexpr const char *errRestoringBackup = "kvrocks is restoring the db 
from backup";
-
 }  // namespace redis

Reply via email to