This is an automated email from the ASF dual-hosted git repository. hulk pushed a commit to branch 2.12 in repository https://gitbox.apache.org/repos/asf/kvrocks.git
commit 85757e755baba40ce9ac92424dd5d9edc51f8fb0 Author: git-hulk <[email protected]> AuthorDate: Thu Apr 17 20:41:30 2025 +0800 Comment out the tdigest and its test cases due to it's not production ready --- src/commands/cmd_tdigest.cc | 12 +++++----- tests/gocase/unit/type/tdigest/tdigest_test.go | 32 +++++++++++++------------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/commands/cmd_tdigest.cc b/src/commands/cmd_tdigest.cc index 166a22afb..a0f6bab4a 100644 --- a/src/commands/cmd_tdigest.cc +++ b/src/commands/cmd_tdigest.cc @@ -243,10 +243,10 @@ class CommandTDigestMax : public CommandTDigestMinMax { CommandTDigestMax() : CommandTDigestMinMax(false) {} }; -REDIS_REGISTER_COMMANDS(TDigest, MakeCmdAttr<CommandTDigestCreate>("tdigest.create", -2, "write", 1, 1, 1), - MakeCmdAttr<CommandTDigestInfo>("tdigest.info", 2, "read-only", 1, 1, 1), - MakeCmdAttr<CommandTDigestAdd>("tdigest.add", -3, "write", 1, 1, 1), - MakeCmdAttr<CommandTDigestMax>("tdigest.max", 2, "read-only", 1, 1, 1), - MakeCmdAttr<CommandTDigestMin>("tdigest.min", 2, "read-only", 1, 1, 1), - MakeCmdAttr<CommandTDigestReset>("tdigest.reset", 2, "write", 1, 1, 1)); +// REDIS_REGISTER_COMMANDS(TDigest, MakeCmdAttr<CommandTDigestCreate>("tdigest.create", -2, "write", 1, 1, 1), +// MakeCmdAttr<CommandTDigestInfo>("tdigest.info", 2, "read-only", 1, 1, 1), +// MakeCmdAttr<CommandTDigestAdd>("tdigest.add", -3, "write", 1, 1, 1), +// MakeCmdAttr<CommandTDigestMax>("tdigest.max", 2, "read-only", 1, 1, 1), +// MakeCmdAttr<CommandTDigestMin>("tdigest.min", 2, "read-only", 1, 1, 1), +// MakeCmdAttr<CommandTDigestReset>("tdigest.reset", 2, "write", 1, 1, 1)); } // namespace redis diff --git a/tests/gocase/unit/type/tdigest/tdigest_test.go b/tests/gocase/unit/type/tdigest/tdigest_test.go index d3f118004..b97dcfd7e 100644 --- a/tests/gocase/unit/type/tdigest/tdigest_test.go +++ b/tests/gocase/unit/type/tdigest/tdigest_test.go @@ -65,22 +65,22 @@ func toTdigestInfo(t *testing.T, value interface{}) tdigestInfo { } } -func TestTDigest(t *testing.T) { - configOptions := []util.ConfigOptions{ - { - Name: "txn-context-enabled", - Options: []string{"yes", "no"}, - ConfigType: util.YesNo, - }, - } - - configsMatrix, err := util.GenerateConfigsMatrix(configOptions) - require.NoError(t, err) - - for _, configs := range configsMatrix { - tdigestTests(t, configs) - } -} +//func TestTDigest(t *testing.T) { +// configOptions := []util.ConfigOptions{ +// { +// Name: "txn-context-enabled", +// Options: []string{"yes", "no"}, +// ConfigType: util.YesNo, +// }, +// } +// +// configsMatrix, err := util.GenerateConfigsMatrix(configOptions) +// require.NoError(t, err) +// +// for _, configs := range configsMatrix { +// tdigestTests(t, configs) +// } +//} func tdigestTests(t *testing.T, configs util.KvrocksServerConfigs) { srv := util.StartServer(t, configs)
