(kvrocks) branch unstable updated: fix(json): use bytes sink for CBOR encoding (#3580)

[jihuayu]

This is an automated email from the ASF dual-hosted git repository.

jihuayu pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git


The following commit(s) were added to refs/heads/unstable by this push:
     new 50cd1f0da fix(json): use bytes sink for CBOR encoding (#3580)
50cd1f0da is described below

commit 50cd1f0da4c3eb8f8c86bad080410e556f18fc98
Author: XYenon <i...@xyenon.bid>
AuthorDate: Sun Aug 9 13:06:10 2026 +0800

    fix(json): use bytes sink for CBOR encoding (#3580)
    
    ## Why
    
    `string_sink<std::string>` is incompatible with jsoncons 1.9.0 because
    the CBOR encoder appends buffers through `const uint8_t *`, while
    `string_sink<std::string>` expects `const char *`.
    
    Use `bytes_sink<std::string>`, which is intended for binary output and
    is also used by jsoncons' `encode_cbor` implementation. It is compatible
    with jsoncons 1.8.1 and 1.9.0 and produces the same serialized CBOR
    output.
    
    Related downstream update: https://github.com/NixOS/nixpkgs/pull/550324
    
    ## Validation
    
    - `./x.py build build-pr --ninja --unittest -j 8`
    - `./x.py test cpp build-pr` — 600 passed, 1 skipped
    - `./x.py test go build-pr -run 'TestJson/JSON_storage_format_CBOR'
    -count=1`
    - `./x.py check format --clang-format-path clang-format-18`
    - `./x.py check tidy build-pr -j 8 --clang-tidy-path clang-tidy-18
    --run-clang-tidy-path run-clang-tidy-18`
    - `./x.py check golangci-lint`
    - `git diff --check`
    
    Prepared with assistance from Amp for investigating jsoncons API
    compatibility, preparing the focused change, and running local
    validation.
---
 src/types/json.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/types/json.h b/src/types/json.h
index 4763f5032..f0de6b83c 100644
--- a/src/types/json.h
+++ b/src/types/json.h
@@ -116,7 +116,7 @@ struct JsonValue {
     jsoncons::cbor::cbor_options options;
     options.max_nesting_depth(max_nesting_depth);
 
-    jsoncons::cbor::basic_cbor_encoder<jsoncons::string_sink<std::string>> 
encoder{*buffer, options};
+    jsoncons::cbor::basic_cbor_encoder<jsoncons::bytes_sink<std::string>> 
encoder{*buffer, options};
     std::error_code ec;
     value.dump(encoder, ec);
     if (ec) {