Repository: kylin Updated Branches: refs/heads/master 0e7658df0 -> be30f4bef
KYLIN-1545 should not setMaxResultSize on hbase scan as it might cause incorrect answers Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/be30f4be Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/be30f4be Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/be30f4be Branch: refs/heads/master Commit: be30f4bef44a3169dfbbd246379c5517fbc866e6 Parents: 0e7658d Author: Hongbin Ma <mahong...@apache.org> Authored: Tue Mar 29 16:58:39 2016 +0800 Committer: Hongbin Ma <mahong...@apache.org> Committed: Tue Mar 29 16:58:39 2016 +0800 ---------------------------------------------------------------------- .../src/main/java/org/apache/kylin/common/KylinConfigBase.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/be30f4be/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java ---------------------------------------------------------------------- diff --git a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java index 6638500..964c562 100644 --- a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java +++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java @@ -478,8 +478,9 @@ public class KylinConfigBase implements Serializable { return Boolean.parseBoolean(this.getOptional("kylin.dict.growing.enabled", "false")); } + //don't change this per https://issues.apache.org/jira/browse/KYLIN-1545 public int getHBaseScanMaxResultSize() { - return Integer.parseInt(this.getOptional("kylin.hbase.scan.max_result_size", "" + (5 * 1024 * 1024))); // 5 MB + return Integer.parseInt(this.getOptional("kylin.hbase.scan.max_result_size", "-1")); } public int getCubingInMemSamplingPercent() {