KYLIN-1731 allow non-admin user to edit 'Advenced Setting' step in CubeDesigner


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/a19b3ae8
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/a19b3ae8
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/a19b3ae8

Branch: refs/heads/master
Commit: a19b3ae86016512294468337785eae6f7a0f80f5
Parents: 1ce8191
Author: Jason <[email protected]>
Authored: Tue May 24 16:54:27 2016 +0800
Committer: Jason <[email protected]>
Committed: Tue May 24 16:56:34 2016 +0800

----------------------------------------------------------------------
 webapp/app/js/controllers/cubeSchema.js | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/a19b3ae8/webapp/app/js/controllers/cubeSchema.js
----------------------------------------------------------------------
diff --git a/webapp/app/js/controllers/cubeSchema.js 
b/webapp/app/js/controllers/cubeSchema.js
index 77909df..2aafd33 100755
--- a/webapp/app/js/controllers/cubeSchema.js
+++ b/webapp/app/js/controllers/cubeSchema.js
@@ -30,12 +30,10 @@ KylinApp.controller('CubeSchemaCtrl', function ($scope, 
QueryService, UserServic
         {title: 'Dimensions', src: 'partials/cubeDesigner/dimensions.html', 
isComplete: false,form:'cube_dimension_form'},
         {title: 'Measures', src: 'partials/cubeDesigner/measures.html', 
isComplete: false,form:'cube_measure_form'},
         {title: 'Refresh Setting', src: 
'partials/cubeDesigner/refresh_settings.html', isComplete: 
false,form:'refresh_setting_form'},
+        {title: 'Advanced Setting', src: 
'partials/cubeDesigner/advanced_settings.html', isComplete: 
false,form:'cube_setting_form'},
+        {title: 'Configuration Overwrites ', src: 
'partials/cubeDesigner/cubeOverwriteProp.html', isComplete: 
false,form:'cube_overwrite_prop_form'},
+        {title: 'Overview', src: 'partials/cubeDesigner/overview.html', 
isComplete: false,form:null}
     ];
-    if (UserService.hasRole("ROLE_ADMIN")) {
-            $scope.wizardSteps.push({title: 'Advanced Setting', src: 
'partials/cubeDesigner/advanced_settings.html', isComplete: 
false,form:'cube_setting_form'});
-    }
-    $scope.wizardSteps.push({title: 'Configuration Overwrites ', src: 
'partials/cubeDesigner/cubeOverwriteProp.html', isComplete: 
false,form:'cube_overwrite_prop_form'});
-    $scope.wizardSteps.push({title: 'Overview', src: 
'partials/cubeDesigner/overview.html', isComplete: false,form:null});
 
     $scope.curStep = $scope.wizardSteps[0];
 

Reply via email to