Repository: kylin Updated Branches: refs/heads/KYLIN-2085 [created] c421a68d1
KYLIN-2085 Consider dynamicVariables in CompareTupleFilter operator swap Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/c421a68d Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/c421a68d Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/c421a68d Branch: refs/heads/KYLIN-2085 Commit: c421a68d12bde096fdf531652b44a35fcb38df5c Parents: ff85103 Author: lidongsjtu <lid...@apache.org> Authored: Wed Oct 12 13:44:11 2016 +0800 Committer: lidongsjtu <lid...@apache.org> Committed: Wed Oct 12 13:44:19 2016 +0800 ---------------------------------------------------------------------- .../java/org/apache/kylin/metadata/filter/CompareTupleFilter.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/c421a68d/core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java index fe51710..c7a3721 100644 --- a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java +++ b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java @@ -75,7 +75,8 @@ public class CompareTupleFilter extends TupleFilter { } this.column = columnFilter.getColumn(); // if value is before column, we need to reverse the operator. e.g. "1 >= c1" => "c1 <= 1" - if (!this.conditionValues.isEmpty() && needSwapOperator()) { + // children.size() > 1 means already added one conditionValue or dynamicVariable + if (this.children.size() > 1 && needSwapOperator()) { this.operator = SWAP_OP_MAP.get(this.operator); TupleFilter last = this.children.remove(this.children.size() - 1); this.children.add(0, last);
