Repository: kylin Updated Branches: refs/heads/master 6b068e36e -> eea4271b3
minor, fix compile warnings Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/eea4271b Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/eea4271b Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/eea4271b Branch: refs/heads/master Commit: eea4271b34b0b5e288f9c310584c1b9d9b7b6b90 Parents: 6b068e3 Author: Li Yang <[email protected]> Authored: Thu Nov 10 13:38:34 2016 +0800 Committer: Li Yang <[email protected]> Committed: Thu Nov 10 13:38:34 2016 +0800 ---------------------------------------------------------------------- .../java/org/apache/kylin/rest/service/ExtFilterService.java | 5 +---- .../src/main/java/org/apache/kylin/rest/service/JobService.java | 1 - .../java/org/apache/kylin/rest/service/KafkaConfigService.java | 4 ---- .../java/org/apache/kylin/rest/service/StreamingService.java | 4 ---- 4 files changed, 1 insertion(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/eea4271b/server-base/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java b/server-base/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java index 0c98965..0a8439d 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java +++ b/server-base/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java @@ -26,17 +26,14 @@ import org.apache.kylin.rest.constant.Constant; import org.apache.kylin.rest.exception.InternalErrorException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.security.access.prepost.PreAuthorize; import org.springframework.stereotype.Component; @Component("extFilterService") public class ExtFilterService extends BasicService { + @SuppressWarnings("unused") private static final Logger logger = LoggerFactory.getLogger(ExtFilterService.class); - @Autowired - private AccessService accessService; - @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN) public void saveExternalFilter(ExternalFilterDesc desc) throws IOException { if (getMetadataManager().getExtFilterDesc(desc.getName()) != null) { http://git-wip-us.apache.org/repos/asf/kylin/blob/eea4271b/server-base/src/main/java/org/apache/kylin/rest/service/JobService.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/JobService.java b/server-base/src/main/java/org/apache/kylin/rest/service/JobService.java index a6a9842..d549fc5 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/service/JobService.java +++ b/server-base/src/main/java/org/apache/kylin/rest/service/JobService.java @@ -87,7 +87,6 @@ import com.google.common.collect.Sets; @Component("jobService") public class JobService extends BasicService implements InitializingBean { - @SuppressWarnings("unused") private static final Logger logger = LoggerFactory.getLogger(JobService.class); private JobLock jobLock; http://git-wip-us.apache.org/repos/asf/kylin/blob/eea4271b/server-base/src/main/java/org/apache/kylin/rest/service/KafkaConfigService.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/KafkaConfigService.java b/server-base/src/main/java/org/apache/kylin/rest/service/KafkaConfigService.java index 1f286e3..f7fc49b 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/service/KafkaConfigService.java +++ b/server-base/src/main/java/org/apache/kylin/rest/service/KafkaConfigService.java @@ -25,16 +25,12 @@ import java.util.List; import org.apache.kylin.rest.constant.Constant; import org.apache.kylin.rest.exception.InternalErrorException; import org.apache.kylin.source.kafka.config.KafkaConfig; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.security.access.prepost.PostFilter; import org.springframework.stereotype.Component; @Component("kafkaMgmtService") public class KafkaConfigService extends BasicService { - @Autowired - private AccessService accessService; - @PostFilter(Constant.ACCESS_POST_FILTER_READ) public List<KafkaConfig> listAllKafkaConfigs(final String kafkaConfigName) throws IOException { List<KafkaConfig> kafkaConfigs = new ArrayList<KafkaConfig>(); http://git-wip-us.apache.org/repos/asf/kylin/blob/eea4271b/server-base/src/main/java/org/apache/kylin/rest/service/StreamingService.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/StreamingService.java b/server-base/src/main/java/org/apache/kylin/rest/service/StreamingService.java index 7310d9c..6f473e2 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/service/StreamingService.java +++ b/server-base/src/main/java/org/apache/kylin/rest/service/StreamingService.java @@ -26,16 +26,12 @@ import org.apache.commons.lang3.StringUtils; import org.apache.kylin.metadata.streaming.StreamingConfig; import org.apache.kylin.rest.constant.Constant; import org.apache.kylin.rest.exception.InternalErrorException; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.security.access.prepost.PostFilter; import org.springframework.stereotype.Component; @Component("streamingMgmtService") public class StreamingService extends BasicService { - @Autowired - private AccessService accessService; - @PostFilter(Constant.ACCESS_POST_FILTER_READ) public List<StreamingConfig> listAllStreamingConfigs(final String table) throws IOException { List<StreamingConfig> streamingConfigs = new ArrayList();
