KYLIN-2588 fix ParameterDesc.equals()

Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/03969236
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/03969236
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/03969236

Branch: refs/heads/KYLIN-2624
Commit: 0396923651cda8428b3022febcf013ff6d0457cf
Parents: 9a0598e
Author: lidongsjtu <lid...@apache.org>
Authored: Fri May 5 18:49:48 2017 +0800
Committer: hongbin ma <m...@kyligence.io>
Committed: Fri May 5 20:56:52 2017 +0800

----------------------------------------------------------------------
 .../java/org/apache/kylin/metadata/model/ParameterDesc.java    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/03969236/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
----------------------------------------------------------------------
diff --git 
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
 
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
index 0cf31b1..930dc02 100644
--- 
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
+++ 
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java
@@ -96,7 +96,7 @@ public class ParameterDesc implements Serializable {
     void setValue(String value) {
         this.value = value;
     }
-    
+
     public TblColRef getColRef() {
         return colRef;
     }
@@ -112,7 +112,7 @@ public class ParameterDesc implements Serializable {
             while (p != null) {
                 if (p.isColumnType())
                     all.add(p.getColRef());
-                
+
                 p = p.nextParameter;
             }
             allColRefsIncludingNexts = all;
@@ -145,7 +145,7 @@ public class ParameterDesc implements Serializable {
             if (p.isColumnType()) {
                 if (q.isColumnType() == false)
                     return false;
-                if (this.getColRef().equals(that.getColRef()) == false)
+                if (q.getColRef().equals(p.getColRef()) == false)
                     return false;
             } else {
                 if (q.isColumnType() == true)

Reply via email to