KYLIN-2777 Should throw error when sql contains non-equi left join

Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/42abb73b
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/42abb73b
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/42abb73b

Branch: refs/heads/2.1.x
Commit: 42abb73bbd734e52e6c8fd1d8c05eec737bbe2ba
Parents: 6d936d3
Author: Roger Shi <rogershijich...@hotmail.com>
Authored: Thu Aug 3 15:19:23 2017 +0800
Committer: Roger Shi <rogershijich...@hotmail.com>
Committed: Thu Aug 3 15:36:32 2017 +0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/kylin/query/optrule/OLAPJoinRule.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/42abb73b/query/src/main/java/org/apache/kylin/query/optrule/OLAPJoinRule.java
----------------------------------------------------------------------
diff --git 
a/query/src/main/java/org/apache/kylin/query/optrule/OLAPJoinRule.java 
b/query/src/main/java/org/apache/kylin/query/optrule/OLAPJoinRule.java
index c31d1d0..5cbc0f0 100644
--- a/query/src/main/java/org/apache/kylin/query/optrule/OLAPJoinRule.java
+++ b/query/src/main/java/org/apache/kylin/query/optrule/OLAPJoinRule.java
@@ -55,7 +55,7 @@ public class OLAPJoinRule extends ConverterRule {
         if (!info.isEqui() && join.getJoinType() != JoinRelType.INNER) {
             // EnumerableJoinRel only supports equi-join. We can put a filter 
on top
             // if it is an inner join.
-            return null;
+            throw new IllegalArgumentException("We only support equi left 
join, please check join conditions!");
         }
 
         RelOptCluster cluster = join.getCluster();

Reply via email to