Minor: add FK-PK string array compare in equals()
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/cfe5c447 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/cfe5c447 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/cfe5c447 Branch: refs/heads/security_update Commit: cfe5c447c1daad3d139a7c6d678e603d5683e8d8 Parents: 7640c94 Author: Yifan Zhang <event.dim...@gmail.com> Authored: Mon Sep 18 00:06:41 2017 +0800 Committer: Dong Li <lid...@apache.org> Committed: Mon Sep 18 01:00:55 2017 +0800 ---------------------------------------------------------------------- .../src/main/java/org/apache/kylin/metadata/model/JoinDesc.java | 5 +++++ 1 file changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/cfe5c447/core-metadata/src/main/java/org/apache/kylin/metadata/model/JoinDesc.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/model/JoinDesc.java b/core-metadata/src/main/java/org/apache/kylin/metadata/model/JoinDesc.java index c8a5110..b16ad7d 100644 --- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/JoinDesc.java +++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/JoinDesc.java @@ -171,7 +171,12 @@ public class JoinDesc implements Serializable { return false; JoinDesc other = (JoinDesc) obj; + // note pk/fk are sorted, sortByFK() + if (!Arrays.equals(foreignKey, other.foreignKey)) + return false; + if (!Arrays.equals(primaryKey, other.primaryKey)) + return false; if (!Arrays.equals(foreignKeyColumns, other.foreignKeyColumns)) return false; if (!Arrays.equals(primaryKeyColumns, other.primaryKeyColumns))
