Repository: kylin Updated Branches: refs/heads/master 31b16c333 -> 11d8f87af
APACHE-KYLIN-2989: Fix close of BufferedWriter should be placed in finally block in SCCreator Signed-off-by: lidongsjtu <lid...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/11d8f87a Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/11d8f87a Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/11d8f87a Branch: refs/heads/master Commit: 11d8f87afbe8c1f3bc61fe18261624e13cdf8a1a Parents: 31b16c3 Author: Zhong <nju_y...@apache.org> Authored: Fri Nov 3 13:17:32 2017 +0800 Committer: lidongsjtu <lid...@apache.org> Committed: Fri Nov 3 13:44:17 2017 +0800 ---------------------------------------------------------------------- .../org/apache/kylin/tool/metrics/systemcube/SCCreator.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/11d8f87a/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java ---------------------------------------------------------------------- diff --git a/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java b/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java index f3bb071..38edb1b 100644 --- a/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java +++ b/tool/src/main/java/org/apache/kylin/tool/metrics/systemcube/SCCreator.java @@ -255,8 +255,8 @@ public class SCCreator extends AbstractApplication { parentDir.mkdirs(); } - BufferedWriter bufferedWriter = new BufferedWriter(new FileWriter(fileName)); - bufferedWriter.append(contents); - bufferedWriter.close(); + try (BufferedWriter bufferedWriter = new BufferedWriter(new FileWriter(fileName))) { + bufferedWriter.append(contents); + } } }
