This is an automated email from the ASF dual-hosted git repository. nic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kylin.git
commit 8bdbdf287ef64afc726e46fba67f4a3ccd3f13e3 Author: etherge <[email protected]> AuthorDate: Thu Jan 23 17:50:36 2020 -0500 minor, sonar issues for ignoring initial values of method parameters --- .../src/main/java/org/apache/kylin/dict/NumberDictionary.java | 10 ++++------ .../src/main/java/org/apache/kylin/dict/NumberDictionary2.java | 4 ++-- .../kylin/sdk/datasource/framework/conv/ConvSqlWriter.java | 8 ++++---- .../src/main/java/org/apache/kylin/engine/mr/CubingJob.java | 1 - 4 files changed, 10 insertions(+), 13 deletions(-) diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java b/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java index 8e59792..083f272 100644 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java @@ -18,7 +18,6 @@ package org.apache.kylin.dict; - import org.apache.kylin.common.util.ClassUtil; /** @@ -29,7 +28,6 @@ import org.apache.kylin.common.util.ClassUtil; @Deprecated public class NumberDictionary<T> extends TrieDictionary<T> { - // ============================================================================ public NumberDictionary() { // default constructor for Writable interface @@ -48,10 +46,10 @@ public class NumberDictionary<T> extends TrieDictionary<T> { @Override protected void setConverterByName(String converterName) throws Exception { - converterName = "org.apache.kylin.dict.Number2BytesConverter"; - this.bytesConvert = ClassUtil.forName(converterName, BytesConverter.class).getDeclaredConstructor().newInstance(); - ((Number2BytesConverter)this.bytesConvert).setMaxDigitsBeforeDecimalPoint(Number2BytesConverter.MAX_DIGITS_BEFORE_DECIMAL_POINT_LEGACY); + this.bytesConvert = ClassUtil.forName("org.apache.kylin.dict.Number2BytesConverter", BytesConverter.class).getDeclaredConstructor() + .newInstance(); + ((Number2BytesConverter) this.bytesConvert) + .setMaxDigitsBeforeDecimalPoint(Number2BytesConverter.MAX_DIGITS_BEFORE_DECIMAL_POINT_LEGACY); } - } \ No newline at end of file diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary2.java b/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary2.java index 24700ca..16cd44f 100644 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary2.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary2.java @@ -39,8 +39,8 @@ public class NumberDictionary2<T> extends NumberDictionary<T> { @Override protected void setConverterByName(String converterName) throws Exception { - converterName = "org.apache.kylin.dict.Number2BytesConverter"; - this.bytesConvert = ClassUtil.forName(converterName, BytesConverter.class).getDeclaredConstructor().newInstance(); + this.bytesConvert = ClassUtil.forName("org.apache.kylin.dict.Number2BytesConverter", BytesConverter.class).getDeclaredConstructor() + .newInstance(); } } diff --git a/datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java b/datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java index eb0630c..4045b93 100644 --- a/datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java +++ b/datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java @@ -217,11 +217,11 @@ public class ConvSqlWriter extends SqlPrettyWriter { public void writeWithItem(SqlCall call, SqlWithItem.SqlWithItemOperator sqlWithItemOperator, int leftPrec, int rightPrec) { final SqlWithItem withItem = (SqlWithItem) call; - leftPrec = sqlWithItemOperator.getLeftPrec(); - rightPrec = sqlWithItemOperator.getRightPrec(); - withItem.name.unparse(this, leftPrec, rightPrec); + int leftP = sqlWithItemOperator.getLeftPrec(); + int rightP = sqlWithItemOperator.getRightPrec(); + withItem.name.unparse(this, leftP, rightP); if (withItem.columnList != null) { - withItem.columnList.unparse(this, leftPrec, rightPrec); + withItem.columnList.unparse(this, leftP, rightP); } this.keyword("AS"); Frame frame = this.startList(FrameTypeEnum.WITH_ITEM, "(", ")"); diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java index c0fc183..568392e 100644 --- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java +++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java @@ -202,7 +202,6 @@ public class CubingJob extends DefaultChainedExecutable { CubeInstance cubeInstance = CubeManager.getInstance(context.getConfig()) .getCube(CubingExecutableUtil.getCubeName(this.getParams())); final Output output = getManager().getOutput(getId()); - state = output.getState(); if (state != ExecutableState.ERROR && !cubeInstance.getDescriptor().getStatusNeedNotify().contains(state.toString())) { logger.info("state:" + state + " no need to notify users");
