This is an automated email from the ASF dual-hosted git repository. xxyu pushed a commit to branch kylin5 in repository https://gitbox.apache.org/repos/asf/kylin.git
The following commit(s) were added to refs/heads/kylin5 by this push: new bb2772794f KYLIN-5228 Fixed length limitation during loading properties to Kylin config. bb2772794f is described below commit bb2772794f587ba4d0e38b2111fb13ce8e5015b8 Author: zhennzhang <zhennzh...@ebay.com> AuthorDate: Mon Aug 15 20:50:38 2022 +0800 KYLIN-5228 Fixed length limitation during loading properties to Kylin config. --- .../org/apache/kylin/common/KylinExternalConfigLoader.java | 9 ++++++--- .../org/apache/kylin/common/TestExternalConfigLoader.java | 14 +++++++++++--- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java b/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java index 4514159faf..fb04d7bbdf 100644 --- a/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java +++ b/src/core-common/src/main/java/org/apache/kylin/common/KylinExternalConfigLoader.java @@ -28,7 +28,6 @@ import java.io.File; import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; -import java.io.PrintWriter; import java.io.StringWriter; import java.net.URL; import java.nio.charset.StandardCharsets; @@ -152,8 +151,12 @@ public class KylinExternalConfigLoader implements IExternalConfigLoader { @Override public String getConfig() { StringWriter writer = new StringWriter(); - properties.list(new PrintWriter(writer)); - return writer.toString(); + try { + properties.store(writer, ""); + } catch (IOException e) { + throw new KylinException(UNKNOWN_ERROR_CODE, e); + } + return writer.getBuffer().toString(); } @Override diff --git a/src/core-common/src/test/java/org/apache/kylin/common/TestExternalConfigLoader.java b/src/core-common/src/test/java/org/apache/kylin/common/TestExternalConfigLoader.java index a6a124d63e..48884e2fb4 100644 --- a/src/core-common/src/test/java/org/apache/kylin/common/TestExternalConfigLoader.java +++ b/src/core-common/src/test/java/org/apache/kylin/common/TestExternalConfigLoader.java @@ -18,10 +18,14 @@ package org.apache.kylin.common; -import java.io.PrintWriter; +import static org.apache.kylin.common.exception.CommonErrorCode.UNKNOWN_ERROR_CODE; + +import java.io.IOException; import java.io.StringWriter; import java.util.Properties; +import org.apache.kylin.common.exception.KylinException; + import io.kyligence.config.core.loader.IExternalConfigLoader; public class TestExternalConfigLoader implements IExternalConfigLoader { @@ -34,8 +38,12 @@ public class TestExternalConfigLoader implements IExternalConfigLoader { @Override public String getConfig() { StringWriter writer = new StringWriter(); - properties.list(new PrintWriter(writer)); - return writer.toString(); + try { + properties.store(writer, ""); + } catch (IOException e) { + throw new KylinException(UNKNOWN_ERROR_CODE, e); + } + return writer.getBuffer().toString(); } @Override